From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] probe command
Date: Tue, 09 Jun 2009 15:23:48 -0400 [thread overview]
Message-ID: <1244575428.4408.26.camel@mj> (raw)
In-Reply-To: <d7ead6de0906091123j5a1269b4h395cd212e5e2213a@mail.gmail.com>
On Tue, 2009-06-09 at 20:23 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Following Pavel's suggestion to make uuid command I implemented probe
> command similar to grub-probe
Great! Please remove trailing whitespace. Please add missing space
after "=" on line 64 in probe.c.
The help doesn't look right (no space before "print filesystem module").
I can have a look how to fix it if you don't find a way. Actually, I
would prefer separate options for targets, as in "search". That would
be:
-l --label
-u --fs_uuid
-p --partmap
-d --driver (instead of "provider")
--target=partmap doesn't work on whole disks.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-06-09 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 18:23 [PATCH] probe command Vladimir 'phcoder' Serbinenko
2009-06-09 19:23 ` Pavel Roskin [this message]
2009-06-09 20:55 ` Vladimir 'phcoder' Serbinenko
2009-06-09 21:48 ` Pavel Roskin
2009-06-10 8:11 ` Vladimir 'phcoder' Serbinenko
2009-06-15 23:26 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244575428.4408.26.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.