From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-core] [PATCH] ksrc: respect struct proc_dir_entry changes in 2.6.30
Date: Thu, 11 Jun 2009 12:37:15 +0200 [thread overview]
Message-ID: <1244716635.7890.134.camel@domain.hid> (raw)
In-Reply-To: <4A30D969.6080501@domain.hid>
On Thu, 2009-06-11 at 12:16 +0200, Jan Kiszka wrote:
> Vladimir Zapolskiy wrote:
> > Hi Jan,
> > I observed that LINUX_VERSION_CODE comparisons are common enough in
> > Xenomai code. Do you propose to make a separate header, which is
> > included from nucleus, drivers and arch files?
>
> Yes, it's common, but we also keep a lot of wrapping in asm-*/wrappers.h.
>
No, it's not that common actually. Most of them are used in the HAL,
half of those in assembly files because we don't have assembly-level
wrappers, and the remaining spots are located in a few RT drivers
(namely serial, CAN and irqbench).
So the canonical way to fix this is indeed to add the proper wrapper to
include/asm-generic/wrappers.h. TIA,
> Jan
>
> PS: Please avoid top-posts.
>
--
Philippe.
next prev parent reply other threads:[~2009-06-11 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 9:16 [Xenomai-core] [PATCH] ksrc: respect struct proc_dir_entry changes in 2.6.30 Vladimir Zapolskiy
2009-06-11 9:32 ` Jan Kiszka
2009-06-11 9:52 ` Vladimir Zapolskiy
2009-06-11 10:16 ` Jan Kiszka
2009-06-11 10:37 ` Philippe Gerum [this message]
2009-06-11 11:51 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244716635.7890.134.camel@domain.hid \
--to=rpm@xenomai.org \
--cc=jan.kiszka@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.