From: Jan Kiszka <jan.kiszka@domain.hid>
To: Vladimir Zapolskiy <vladimir.zapolskiy@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-core] [PATCH] ksrc: respect struct proc_dir_entry changes in 2.6.30
Date: Thu, 11 Jun 2009 11:32:57 +0200 [thread overview]
Message-ID: <4A30CF49.8010007@domain.hid> (raw)
In-Reply-To: <4A30CB83.5080504@domain.hid>
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
Hi Vladimir,
Vladimir Zapolskiy wrote:
> Hello,
>
> please apply the attached simple patch, which resolves a kind of
> compilation problems against 2.6.30 kernel.
>
> --
> With best wishes,
> Vladimir
>
> From 894660f7dc91b406d8e078247b46606778562de9 Mon Sep 17 00:00:00 2001
> From: Vladimir Zapolskiy <vladimir.zapolskiy@domain.hid>
> Date: Thu, 11 Jun 2009 12:32:00 +0400
> Subject: [PATCH] Made conditional inclusion of owner field in struct proc_dir_entry due to changes in 2.6.30
>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@domain.hid>
> ---
> ksrc/arch/generic/hal.c | 6 ++++++
> ksrc/drivers/comedi/device.c | 2 ++
> ksrc/drivers/comedi/rtdm_interface.c | 4 ++++
> ksrc/nucleus/registry.c | 2 ++
> 4 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/ksrc/arch/generic/hal.c b/ksrc/arch/generic/hal.c
> index e4f0f31..b983b68 100644
> --- a/ksrc/arch/generic/hal.c
> +++ b/ksrc/arch/generic/hal.c
> @@ -738,7 +738,9 @@ struct proc_dir_entry *rthal_add_proc_leaf(const char *name,
> entry->data = data;
> entry->read_proc = rdproc;
> entry->write_proc = wrproc;
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,30)
> entry->owner = THIS_MODULE;
> +#endif
I would suggest to squeeze all these assignments into a helper function
that is void from 2.6.30 on, hiding the #ifdefs
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-06-11 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 9:16 [Xenomai-core] [PATCH] ksrc: respect struct proc_dir_entry changes in 2.6.30 Vladimir Zapolskiy
2009-06-11 9:32 ` Jan Kiszka [this message]
2009-06-11 9:52 ` Vladimir Zapolskiy
2009-06-11 10:16 ` Jan Kiszka
2009-06-11 10:37 ` Philippe Gerum
2009-06-11 11:51 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A30CF49.8010007@domain.hid \
--to=jan.kiszka@domain.hid \
--cc=vladimir.zapolskiy@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.