All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	mingo@elte.hu
Subject: Re: slab: setup allocators earlier in the boot sequence
Date: Fri, 12 Jun 2009 18:47:06 +1000	[thread overview]
Message-ID: <1244796426.7172.90.camel@pasglop> (raw)
In-Reply-To: <1244794648.30512.21.camel@penberg-laptop>

On Fri, 2009-06-12 at 11:17 +0300, Pekka Enberg wrote:
> Hi Ben,
> 
> On Fri, 2009-06-12 at 17:39 +1000, Benjamin Herrenschmidt wrote:
> > For example, slab_is_available() didn't always exist, and so in the
> > early days on powerpc, we used a mem_init_done global that is set form
> > mem_init() (not perfect but works in practice). And we still have code
> > using that to do the test.
> 
> Looking at powerpc arch code, can we get rid of the *_maybe_bootmem()
> functions now? Or is slab initialization too late still? FWIW, I think
> one simple fix on PPC is to just clear __GFP_NOWAIT in those functions
> (all of them seem to be using GFP_KERNEL which is wrong during boot).

I -think- we still use those in setup_arch() so we can't get rid of that
completely yet.

Cheers,
Ben.

> 			Pekka
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>


WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	mingo@elte.hu
Subject: Re: slab: setup allocators earlier in the boot sequence
Date: Fri, 12 Jun 2009 18:47:06 +1000	[thread overview]
Message-ID: <1244796426.7172.90.camel@pasglop> (raw)
In-Reply-To: <1244794648.30512.21.camel@penberg-laptop>

On Fri, 2009-06-12 at 11:17 +0300, Pekka Enberg wrote:
> Hi Ben,
> 
> On Fri, 2009-06-12 at 17:39 +1000, Benjamin Herrenschmidt wrote:
> > For example, slab_is_available() didn't always exist, and so in the
> > early days on powerpc, we used a mem_init_done global that is set form
> > mem_init() (not perfect but works in practice). And we still have code
> > using that to do the test.
> 
> Looking at powerpc arch code, can we get rid of the *_maybe_bootmem()
> functions now? Or is slab initialization too late still? FWIW, I think
> one simple fix on PPC is to just clear __GFP_NOWAIT in those functions
> (all of them seem to be using GFP_KERNEL which is wrong during boot).

I -think- we still use those in setup_arch() so we can't get rid of that
completely yet.

Cheers,
Ben.

> 			Pekka
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-06-12  8:47 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200906111959.n5BJxFj9021205@hera.kernel.org>
2009-06-12  1:29 ` slab: setup allocators earlier in the boot sequence Benjamin Herrenschmidt
2009-06-12  1:30 ` Benjamin Herrenschmidt
2009-06-12  3:56   ` Benjamin Herrenschmidt
2009-06-12  4:25     ` Benjamin Herrenschmidt
2009-06-12  5:07       ` Benjamin Herrenschmidt
2009-06-12  5:07         ` Benjamin Herrenschmidt
2009-06-12  6:16         ` Pekka J Enberg
2009-06-12  6:16           ` Pekka J Enberg
2009-06-12  7:34           ` Benjamin Herrenschmidt
2009-06-12  7:34             ` Benjamin Herrenschmidt
2009-06-12  7:39             ` Benjamin Herrenschmidt
2009-06-12  7:39               ` Benjamin Herrenschmidt
2009-06-12  7:47               ` Pekka Enberg
2009-06-12  7:47                 ` Pekka Enberg
2009-06-12  8:17               ` Pekka Enberg
2009-06-12  8:17                 ` Pekka Enberg
2009-06-12  8:47                 ` Benjamin Herrenschmidt [this message]
2009-06-12  8:47                   ` Benjamin Herrenschmidt
2009-06-12  7:45             ` Pekka Enberg
2009-06-12  7:45               ` Pekka Enberg
2009-06-12  7:54               ` Nick Piggin
2009-06-12  7:54                 ` Nick Piggin
2009-06-12  7:59                 ` Pekka Enberg
2009-06-12  7:59                   ` Pekka Enberg
2009-06-12  8:02                   ` Nick Piggin
2009-06-12  8:02                     ` Nick Piggin
2009-06-12  8:04                     ` Pekka Enberg
2009-06-12  8:04                       ` Pekka Enberg
2009-06-12  8:20                       ` Nick Piggin
2009-06-12  8:20                         ` Nick Piggin
2009-06-12  8:44                       ` Benjamin Herrenschmidt
2009-06-12  8:44                         ` Benjamin Herrenschmidt
2009-06-12  8:49                         ` Pekka Enberg
2009-06-12  8:49                           ` Pekka Enberg
2009-06-12  9:13                           ` Nick Piggin
2009-06-12  9:13                             ` Nick Piggin
2009-06-12  9:24                             ` Benjamin Herrenschmidt
2009-06-12  9:24                               ` Benjamin Herrenschmidt
2009-06-12  9:30                               ` Nick Piggin
2009-06-12  9:30                                 ` Nick Piggin
2009-06-12  9:44                                 ` Benjamin Herrenschmidt
2009-06-12  9:44                                   ` Benjamin Herrenschmidt
2009-06-12  9:49                                   ` Nick Piggin
2009-06-12  9:49                                     ` Nick Piggin
2009-06-12  8:44                     ` Benjamin Herrenschmidt
2009-06-12  8:44                       ` Benjamin Herrenschmidt
2009-06-12  8:42                 ` Benjamin Herrenschmidt
2009-06-12  8:42                   ` Benjamin Herrenschmidt
2009-06-12  8:40               ` Benjamin Herrenschmidt
2009-06-12  8:40                 ` Benjamin Herrenschmidt
2009-06-12  8:43                 ` Pekka Enberg
2009-06-12  8:43                   ` Pekka Enberg
2009-06-12  8:53                   ` Benjamin Herrenschmidt
2009-06-12  8:53                     ` Benjamin Herrenschmidt
2009-06-12  9:05                     ` Pekka Enberg
2009-06-12  9:05                       ` Pekka Enberg
2009-06-12  9:14                       ` Nick Piggin
2009-06-12  9:14                         ` Nick Piggin
2009-06-12  9:07                     ` Pekka Enberg
2009-06-12  9:07                       ` Pekka Enberg
2009-06-12 13:49                       ` Christoph Lameter
2009-06-12 13:49                         ` Christoph Lameter
2009-06-12 13:54                         ` Pekka Enberg
2009-06-12 13:54                           ` Pekka Enberg
2009-06-12 14:02                           ` Benjamin Herrenschmidt
2009-06-12 14:02                             ` Benjamin Herrenschmidt
2009-06-12 14:04                             ` Pekka Enberg
2009-06-12 14:04                               ` Pekka Enberg
2009-06-12 14:07                           ` Christoph Lameter
2009-06-12 14:07                             ` Christoph Lameter
2009-06-12 14:00                         ` Benjamin Herrenschmidt
2009-06-12 14:00                           ` Benjamin Herrenschmidt
2009-06-12 13:44                   ` Christoph Lameter
2009-06-12 13:44                     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244796426.7172.90.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.