All of lore.kernel.org
 help / color / mirror / Atom feed
From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: "Figo.zhang" <figo1802@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
	Sumit Panchasara <sumit.panchasara@einfochips.com>,
	"'Sachin P Sant'" <sachinp@linux.vnet.ibm.com>,
	"'H. Peter Anvin'" <hpa@zytor.com>,
	"'Frans Pop'" <elendil@planet.nl>,
	"'Andi Kleen'" <andi@firstfloor.org>,
	"'Thomas Gleixner'" <tglx@linutronix.de>,
	"'Balbir Singh'" <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH]x86-tsc.c : fix compile warning
Date: Wed, 17 Jun 2009 19:47:21 +0530	[thread overview]
Message-ID: <1245248241.4870.12.camel@subratamodak.linux.ibm.com> (raw)
In-Reply-To: <bb33bcf20906170700i4a4ea802yf1da08e9870d6221@mail.gmail.com>

> fix compile warning:
> arch/x86/kernel/tsc.c: In function ‘time_cpufreq_notifier’:
> arch/x86/kernel/tsc.c:635: warning: ‘dummy’ may be used uninitialized in
> this function
> 
> Signed-off-by: Figo.zhang <figo1802@gmail.com>

Hello Figo,

Please refer to the following links on discussion on this issue earlier:
http://lkml.org/lkml/2009/5/19/312
http://lkml.org/lkml/2009/5/19/301
http://lkml.org/lkml/2009/5/20/23

I tried to fix it in some other way.

Regards--
Subrata

> ---
> arch/x86/kernel/tsc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index ae3180c..e65492a 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -632,7 +632,7 @@ static int time_cpufreq_notifier(struct
> notifier_block *nb, unsigned long val,
>                                void *data)
>  {
>        struct cpufreq_freqs *freq = data;
> -       unsigned long *lpj, dummy;
> +       unsigned long *lpj, dummy = 0;
> 
>        if (cpu_has(&cpu_data(freq->cpu), X86_FEATURE_CONSTANT_TSC))
>                return 0;
> 



  parent reply	other threads:[~2009-06-17 14:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 13:57 [PATCH]x86-tsc.c : fix compile warning Figo.zhang
     [not found] ` <bb33bcf20906170700i4a4ea802yf1da08e9870d6221@mail.gmail.com>
2009-06-17 14:17   ` Subrata Modak [this message]
2009-06-17 14:20     ` Figo.zhang
2009-06-17 15:28     ` Ingo Molnar
2009-06-17 16:11       ` Subrata Modak
2009-06-17 16:12       ` Frans Pop
2009-06-17 16:23         ` Ingo Molnar
2009-06-17 16:55           ` Subrata Modak
2009-06-18  7:27           ` Balbir Singh
2009-06-18  8:48             ` Subrata Modak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245248241.4870.12.camel@subratamodak.linux.ibm.com \
    --to=subrata@linux.vnet.ibm.com \
    --cc=andi@firstfloor.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=elendil@planet.nl \
    --cc=figo1802@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sachinp@linux.vnet.ibm.com \
    --cc=sumit.panchasara@einfochips.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.