From: Frans Pop <elendil@planet.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Subrata Modak <subrata@linux.vnet.ibm.com>,
"Figo.zhang" <figo1802@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Sumit Panchasara <sumit.panchasara@einfochips.com>,
"'Sachin P Sant'" <sachinp@linux.vnet.ibm.com>,
"'H. Peter Anvin'" <hpa@zytor.com>,
"'Andi Kleen'" <andi@firstfloor.org>,
"'Thomas Gleixner'" <tglx@linutronix.de>,
"'Balbir Singh'" <balbir@linux.vnet.ibm.com>,
Jaswinder Singh Rajput <jaswinder@kernel.org>
Subject: Re: [PATCH]x86-tsc.c : fix compile warning
Date: Wed, 17 Jun 2009 18:12:49 +0200 [thread overview]
Message-ID: <200906171812.51478.elendil@planet.nl> (raw)
In-Reply-To: <20090617152802.GB6042@elte.hu>
On Wednesday 17 June 2009, Ingo Molnar wrote:
> Ah, and you fixed in what a superior way: you improved the code in
> the process :-) This is how warnings should be fixed really.
Hmm. Did you also see Pavel's reply to that patch [1]:
! But that's a bug to be fixed, I'd say? ... actually I believe you are
! introducing a bug here. Yes, old code would put random numbers in
! loops_per_jiffy_ref for !CPUFREQ_CONST_LOOPS, but you are introducing
! oops there.
Was his comment incorrect?
Cheers,
FJP
[1] http://lkml.org/lkml/2009/5/24/159
next prev parent reply other threads:[~2009-06-17 16:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 13:57 [PATCH]x86-tsc.c : fix compile warning Figo.zhang
[not found] ` <bb33bcf20906170700i4a4ea802yf1da08e9870d6221@mail.gmail.com>
2009-06-17 14:17 ` Subrata Modak
2009-06-17 14:20 ` Figo.zhang
2009-06-17 15:28 ` Ingo Molnar
2009-06-17 16:11 ` Subrata Modak
2009-06-17 16:12 ` Frans Pop [this message]
2009-06-17 16:23 ` Ingo Molnar
2009-06-17 16:55 ` Subrata Modak
2009-06-18 7:27 ` Balbir Singh
2009-06-18 8:48 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906171812.51478.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=figo1802@gmail.com \
--cc=hpa@zytor.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sachinp@linux.vnet.ibm.com \
--cc=subrata@linux.vnet.ibm.com \
--cc=sumit.panchasara@einfochips.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.