From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] fix SigSegV and hang with grub-emu-usb
Date: Fri, 19 Jun 2009 11:20:52 -0400 [thread overview]
Message-ID: <1245424852.3431.30.camel@mj> (raw)
In-Reply-To: <d7ead6de0906190758l35021d68v6843251a42f1e0d2@mail.gmail.com>
On Fri, 2009-06-19 at 16:58 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello when testing grub-emu with USB support I stumbled across several problems
> 1) compile time warning of undefined grub_usb_libinit
> 2) When launched under normal user it crashed
> 3) When launched as superuser it hanged on ls
> Here is the fix. Formatting omitted for readability
It's not clear which changes are responsible for fixing which problems.
Please post separate patches if you want a meaningful review.
Regarding the compile warning fix, I would try to make
grub_libusb_init() and grub_libusb_fini() appear in grub_emu_init.h
rather than declare them elsewhere.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-06-19 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 14:58 [PATCH] fix SigSegV and hang with grub-emu-usb Vladimir 'phcoder' Serbinenko
2009-06-19 15:20 ` Pavel Roskin [this message]
2009-06-19 15:54 ` Vladimir 'phcoder' Serbinenko
2009-06-19 16:52 ` Pavel Roskin
2009-06-19 18:44 ` Vladimir 'phcoder' Serbinenko
2009-06-19 19:14 ` Vladimir 'phcoder' Serbinenko
2009-06-19 21:47 ` Pavel Roskin
2009-06-19 21:56 ` Vladimir 'phcoder' Serbinenko
2009-07-16 15:36 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245424852.3431.30.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.