All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [2342] 2009-06-18  Vladimir Serbinenko  <phcoder@gmail.com>
Date: Fri, 19 Jun 2009 17:33:11 -0400	[thread overview]
Message-ID: <1245447191.672.5.camel@mj> (raw)
In-Reply-To: <4A3BEF72.1050005@t-online.de>

On Fri, 2009-06-19 at 22:05 +0200, Christian Franke wrote:

> This was the AC_MSG_RESULT(...) for the
> AC_MSG_CHECKING([for option to link raw image])
> which is still present for the "$grub_cv_apple_target_cc" != "yes"  case.
> 
> I would suggest to move the AC_MSG_CHECKING outside the 'if 
> "$grub_cv_apple_target_cc" = "yes" ... fi' and re-add the AC_MSG_RESULT.

Thanks for pointing it out.  Actually, the message is not needed at all.
There is no "checking" that needs to be communicated to the user.  It
would be appropriate if configure was running a compiler or looked for
some tool in the PATH.  In this case, it's just shell variable
assignments with on test for a file.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2009-06-19 21:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1MHIC7-000500-F0@cvs.savannah.gnu.org>
2009-06-19 20:05 ` [2342] 2009-06-18 Vladimir Serbinenko <phcoder@gmail.com> Christian Franke
2009-06-19 21:33   ` Pavel Roskin [this message]
2009-06-20  7:04     ` Christian Franke
2009-06-22 21:48       ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245447191.672.5.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.