From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] File access library for lua
Date: Sun, 21 Jun 2009 20:42:33 -0400 [thread overview]
Message-ID: <1245631353.9864.7.camel@mj> (raw)
In-Reply-To: <ca0f59980906210433j1d89d0a6td3a9add7a427ae11@mail.gmail.com>
On Sun, 2009-06-21 at 19:33 +0800, Bean wrote:
> I've added a few function in the lua grub library to access files:
...
> I also enable the string library from lua.
The patch doesn't introduce any compiler warnings, and that's good.
It makes lua.mod bigger by about 10%, but it's very little compared to
the added functionality.
Please don't add trailing whitespace. STGit detects it in two places.
There are several cases of missing spaces before parentheses.
We probably need NESTED_FUNC_ATTR in the dir definition in struct
grub_fs, as it takes two arguments. But is a separate issue.
I'm feeling uneasy about having a parser in GRUB that is not used by
default, but it's not related to the quality of the patch.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-06-22 0:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 11:33 [PATCH] File access library for lua Bean
2009-06-22 0:42 ` Pavel Roskin [this message]
2009-06-22 3:38 ` Bean
2009-06-22 3:45 ` Pavel Roskin
2009-06-22 9:44 ` Robert Millan
2009-06-22 10:26 ` Bean
2009-06-22 10:59 ` Robert Millan
2009-06-22 17:37 ` Bean
2009-06-22 18:31 ` Pavel Roskin
2009-06-22 18:49 ` Bean
2009-06-22 18:59 ` Pavel Roskin
2009-06-22 19:15 ` Bean
2009-06-22 19:28 ` Pavel Roskin
2009-06-22 19:50 ` Bean
2009-06-22 20:06 ` Pavel Roskin
2009-06-23 9:27 ` Bean
2009-06-23 22:10 ` Pavel Roskin
2009-06-23 22:50 ` Robert Millan
2009-06-26 23:25 ` Pavel Roskin
2009-06-24 4:41 ` Bean
2009-06-24 5:58 ` Bean
2009-06-27 0:22 ` Pavel Roskin
2009-06-27 3:53 ` Bean
2009-06-27 4:04 ` Pavel Roskin
2009-06-27 4:14 ` Bean
2009-07-05 9:59 ` Bean
2009-07-05 13:11 ` Duboucher Thomas
2009-07-05 14:28 ` Bean
2009-06-25 22:39 ` Vladimir 'phcoder' Serbinenko
2009-06-26 23:45 ` Pavel Roskin
2009-07-31 8:07 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245631353.9864.7.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.