From: Chandra Seetharaman <sekharan@us.ibm.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: RDAC path checker status change messages
Date: Wed, 24 Jun 2009 11:15:21 -0700 [thread overview]
Message-ID: <1245867321.26915.13.camel@chandra-ubuntu> (raw)
In-Reply-To: <Pine.LNX.4.64.0906231548060.18687@e-smith.charlieb.ott.istop.com>
Hi Charlie,
We do not want to print these messages as they will be flooding
your /var/log/messages even when everything is good.
We want to print these messages only to get User's attention.
If your concern is that the last message is "down", then we should be
having a static variable and print up or ghost message only once (when
we toggle from down to up/ghost).
chandra
On Tue, 2009-06-23 at 15:50 -0400, Charlie Brady wrote:
> It seems to me that this patch is required, to fix a problem with "path
> down" messages being logged when the path transitions to up (and
> presumably ghost).
>
> --- libcheckers/rdac.c.orig 2009-06-23 15:38:05.371422000 -0400
> +++ libcheckers/rdac.c 2009-06-23 15:39:28.020843000 -0400
> @@ -105,5 +105,12 @@
> return PATH_DOWN;
> }
>
> - return ((inq.avtcvp & 0x1) ? PATH_UP : PATH_GHOST);
> + if (inq.avtcvp & 0x1) {
> + MSG(c, MSG_RDAC_UP);
> + return PATH_UP;
> + }
> + else {
> + MSG(c, MSG_RDAC_GHOST);
> + return PATH_GHOST;
> + }
> }
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2009-06-24 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 19:50 RDAC path checker status change messages Charlie Brady
2009-06-24 18:15 ` Chandra Seetharaman [this message]
2009-06-24 20:19 ` Charlie Brady
2009-06-24 21:01 ` Benjamin Marzinski
2009-06-25 16:57 ` Charlie Brady
2009-06-25 17:02 ` Charlie Brady
2009-06-25 17:28 ` Charlie Brady
2009-06-26 16:07 ` Benjamin Marzinski
2009-06-25 18:29 ` Chandra Seetharaman
2009-06-25 18:40 ` Charlie Brady
2010-11-03 21:09 ` Mike Snitzer
2010-11-03 22:16 ` Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245867321.26915.13.camel@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=dm-devel@redhat.com \
--cc=sekharan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.