From: David Woodhouse <dwmw2@infradead.org>
To: vimal singh <vimalsingh@ti.com>
Cc: "david-b@pacbell.net" <david-b@pacbell.net>,
"tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][MTD][NAND]: fix omap2.c compile failure and warning
Date: Fri, 26 Jun 2009 18:14:02 +0100 [thread overview]
Message-ID: <1246036442.663.47.camel@macbook.infradead.org> (raw)
In-Reply-To: <57946.192.168.10.89.1246035773.squirrel@dbdmail.itg.ti.com>
On Fri, 2009-06-26 at 22:32 +0530, vimal singh wrote:
> Somehow I do not see below errors on compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_wait':
> drivers/mtd/nand/omap2.c:543: error: 'jiffies' undeclared (first use in this
> function)
> drivers/mtd/nand/omap2.c:543: error: (Each undeclared identifier is reported
> only once
> drivers/mtd/nand/omap2.c:543: error: for each function it appears in.)
> drivers/mtd/nand/omap2.c:557: error: implicit declaration of function
> 'time_before'
>
> But still including 'linux/jiffies.h'.
>
> Below is the patch.
The 'status' you return in the case that you _have_ gone through the
loop is still wrong though, isn't it?
--
dwmw2
WARNING: multiple messages have this Message-ID (diff)
From: David Woodhouse <dwmw2@infradead.org>
To: vimal singh <vimalsingh@ti.com>
Cc: "tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"david-b@pacbell.net" <david-b@pacbell.net>
Subject: Re: [PATCH][MTD][NAND]: fix omap2.c compile failure and warning
Date: Fri, 26 Jun 2009 18:14:02 +0100 [thread overview]
Message-ID: <1246036442.663.47.camel@macbook.infradead.org> (raw)
In-Reply-To: <57946.192.168.10.89.1246035773.squirrel@dbdmail.itg.ti.com>
On Fri, 2009-06-26 at 22:32 +0530, vimal singh wrote:
> Somehow I do not see below errors on compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_wait':
> drivers/mtd/nand/omap2.c:543: error: 'jiffies' undeclared (first use in this
> function)
> drivers/mtd/nand/omap2.c:543: error: (Each undeclared identifier is reported
> only once
> drivers/mtd/nand/omap2.c:543: error: for each function it appears in.)
> drivers/mtd/nand/omap2.c:557: error: implicit declaration of function
> 'time_before'
>
> But still including 'linux/jiffies.h'.
>
> Below is the patch.
The 'status' you return in the case that you _have_ gone through the
loop is still wrong though, isn't it?
--
dwmw2
next prev parent reply other threads:[~2009-06-26 17:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53729.192.168.10.89.1246035472.squirrel@dbdmail.itg.ti.com>
2009-06-26 17:02 ` [PATCH][MTD][NAND]: fix omap2.c compile failure and warning vimal singh
2009-06-26 17:02 ` vimal singh
2009-06-26 17:14 ` David Woodhouse [this message]
2009-06-26 17:14 ` David Woodhouse
[not found] ` <57946.192.168.10.89.1246035774.squirrel@dbdmail.itg.ti.com>
2009-06-27 5:37 ` vimal singh
2009-06-27 5:37 ` vimal singh
2009-06-27 7:45 ` David Woodhouse
2009-06-27 7:45 ` David Woodhouse
2009-06-28 5:40 vimal singh
-- strict thread matches above, loose matches on Subject: below --
2009-06-26 13:21 tom.leiming
2009-06-26 13:21 ` tom.leiming
2009-06-26 15:09 ` David Woodhouse
2009-06-26 15:09 ` David Woodhouse
2009-06-26 15:45 ` Singh, Vimal
2009-06-26 15:45 ` Singh, Vimal
2009-06-26 16:18 ` David Woodhouse
2009-06-26 16:18 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246036442.663.47.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tom.leiming@gmail.com \
--cc=vimalsingh@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.