From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}
Date: Mon, 29 Jun 2009 00:09:16 -0400 [thread overview]
Message-ID: <1246248556.22661.24.camel@mj> (raw)
In-Reply-To: <20090627121216.GA29067@thorin>
On Sat, 2009-06-27 at 14:12 +0200, Robert Millan wrote:
> This patch makes GRUB gather the -boot parameter from CMOS and
> export it as a set of variables (qemu_boot{0,1,2}), which can
> be observed in grub.cfg scripts.
I think qemu constants belong to a separate header.
Use of a nested function seems totally unwarranted. We actually agreed
a while ago that they are bad, but nobody had time to remove them.
Please use ARRAY_SIZE to calculate the number of elements.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-06-29 4:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-27 12:12 [PATCH] export -boot parameter as qemu_boot{0,1,2} Robert Millan
2009-06-29 4:09 ` Pavel Roskin [this message]
2009-06-29 13:49 ` Robert Millan
2009-06-29 20:18 ` Vladimir 'phcoder' Serbinenko
2009-06-29 22:31 ` Pavel Roskin
2009-06-29 22:59 ` Pavel Roskin
2009-07-01 12:58 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246248556.22661.24.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.