All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Daniel Mack <daniel@caiaq.de>
Cc: Adrian Hunter <adrian.hunter@nokia.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] ubifs: allow more than one volume to be mounted
Date: Thu, 02 Jul 2009 18:34:50 +0300	[thread overview]
Message-ID: <1246548890.20721.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20090702152730.GJ18340@buzzloop.caiaq.de>

On Thu, 2009-07-02 at 17:27 +0200, Daniel Mack wrote:
> On Thu, Jul 02, 2009 at 06:17:45PM +0300, Artem Bityutskiy wrote:
> > Daniel Mack wrote:
> >> UBIFS uses a bdi device per volume, but does not care to hand out unique
> >> names to each of them. This causes an error when trying to mount more
> >> than one volumes.
> >>
> >> [  239.277407] kobject_add_internal failed for ubifs with -EEXIST, don't try to register things with the same name in the same directory.
> >> [  239.289618] [<c002a45c>] (unwind_backtrace+0x0/0xdc) from [<c0160628>] (kobject_add_internal+0x188/0x1b8)
> >> [  239.299445] [<c0160628>] (kobject_add_internal+0x188/0x1b8) from [<c01607d8>] (kobject_add+0x48/0x5c)
> >> [  239.308896] [<c01607d8>] (kobject_add+0x48/0x5c) from [<c019d96c>] (device_add+0xac/0x510)
> >> [  239.317392] [<c019d96c>] (device_add+0xac/0x510) from [<c019de58>] (device_create_vargs+0x70/0xa4)
> >> [  239.326589] [<c019de58>] (device_create_vargs+0x70/0xa4) from [<c0073138>] (bdi_register+0x44/0x64)
> >> [  239.335854] [<c0073138>] (bdi_register+0x44/0x64) from [<c01249f0>] (ubifs_get_sb+0x3c8/0x10cc)
> >> [  239.344769] [<c01249f0>] (ubifs_get_sb+0x3c8/0x10cc) from [<c008b054>] (vfs_kern_mount+0x50/0xa8)
> >> [  239.353867] [<c008b054>] (vfs_kern_mount+0x50/0xa8) from [<c008b0f0>] (do_kern_mount+0x34/0xd0)
> >> [  239.362799] [<c008b0f0>] (do_kern_mount+0x34/0xd0) from [<c009f7b4>] (do_mount+0x644/0x6b4)
> >> [  239.371377] [<c009f7b4>] (do_mount+0x644/0x6b4) from [<c009f8a8>] (sys_mount+0x84/0xcc)
> >> [  239.379538] [<c009f8a8>] (sys_mount+0x84/0xcc) from [<c0025e80>] (ret_fast_syscall+0x0/0x2c)
> >>
> >> Append the UBI volume and device ID to avoid that.
> >>
> >> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> >> Cc: Artem Bityutskiy <dedekind@infradead.org>
> >> Cc: Adrian Hunter <ext-adrian.hunter@nokia.com>
> >> Cc: linux-mtd@lists.infradead.org
> >
> > Thanks, I'll look at this tomorrow and try to sent it to Linus
> > ASAP.
> 
> Btw - Adrian Hunter's email in MAINTAINERS seems to be outdated:
> 
> <ext-adrian.hunter@nokia.com>: host mx1.nokia.com[192.100.122.228] said:
> 550 5.1.1 <ext-adrian.hunter@nokia.com>... User unknown (in reply to RCPT TO command)

Ok, I'll fix that too, thanks. Nowadays it is: adrian.hunter@nokia.com

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind@infradead.org>
To: Daniel Mack <daniel@caiaq.de>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@nokia.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] ubifs: allow more than one volume to be mounted
Date: Thu, 02 Jul 2009 18:34:50 +0300	[thread overview]
Message-ID: <1246548890.20721.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20090702152730.GJ18340@buzzloop.caiaq.de>

On Thu, 2009-07-02 at 17:27 +0200, Daniel Mack wrote:
> On Thu, Jul 02, 2009 at 06:17:45PM +0300, Artem Bityutskiy wrote:
> > Daniel Mack wrote:
> >> UBIFS uses a bdi device per volume, but does not care to hand out unique
> >> names to each of them. This causes an error when trying to mount more
> >> than one volumes.
> >>
> >> [  239.277407] kobject_add_internal failed for ubifs with -EEXIST, don't try to register things with the same name in the same directory.
> >> [  239.289618] [<c002a45c>] (unwind_backtrace+0x0/0xdc) from [<c0160628>] (kobject_add_internal+0x188/0x1b8)
> >> [  239.299445] [<c0160628>] (kobject_add_internal+0x188/0x1b8) from [<c01607d8>] (kobject_add+0x48/0x5c)
> >> [  239.308896] [<c01607d8>] (kobject_add+0x48/0x5c) from [<c019d96c>] (device_add+0xac/0x510)
> >> [  239.317392] [<c019d96c>] (device_add+0xac/0x510) from [<c019de58>] (device_create_vargs+0x70/0xa4)
> >> [  239.326589] [<c019de58>] (device_create_vargs+0x70/0xa4) from [<c0073138>] (bdi_register+0x44/0x64)
> >> [  239.335854] [<c0073138>] (bdi_register+0x44/0x64) from [<c01249f0>] (ubifs_get_sb+0x3c8/0x10cc)
> >> [  239.344769] [<c01249f0>] (ubifs_get_sb+0x3c8/0x10cc) from [<c008b054>] (vfs_kern_mount+0x50/0xa8)
> >> [  239.353867] [<c008b054>] (vfs_kern_mount+0x50/0xa8) from [<c008b0f0>] (do_kern_mount+0x34/0xd0)
> >> [  239.362799] [<c008b0f0>] (do_kern_mount+0x34/0xd0) from [<c009f7b4>] (do_mount+0x644/0x6b4)
> >> [  239.371377] [<c009f7b4>] (do_mount+0x644/0x6b4) from [<c009f8a8>] (sys_mount+0x84/0xcc)
> >> [  239.379538] [<c009f8a8>] (sys_mount+0x84/0xcc) from [<c0025e80>] (ret_fast_syscall+0x0/0x2c)
> >>
> >> Append the UBI volume and device ID to avoid that.
> >>
> >> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> >> Cc: Artem Bityutskiy <dedekind@infradead.org>
> >> Cc: Adrian Hunter <ext-adrian.hunter@nokia.com>
> >> Cc: linux-mtd@lists.infradead.org
> >
> > Thanks, I'll look at this tomorrow and try to sent it to Linus
> > ASAP.
> 
> Btw - Adrian Hunter's email in MAINTAINERS seems to be outdated:
> 
> <ext-adrian.hunter@nokia.com>: host mx1.nokia.com[192.100.122.228] said:
> 550 5.1.1 <ext-adrian.hunter@nokia.com>... User unknown (in reply to RCPT TO command)

Ok, I'll fix that too, thanks. Nowadays it is: adrian.hunter@nokia.com

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)


  reply	other threads:[~2009-07-02 15:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02 15:15 [PATCH] ubifs: allow more than one volume to be mounted Daniel Mack
2009-07-02 15:15 ` Daniel Mack
2009-07-02 15:17 ` Artem Bityutskiy
2009-07-02 15:17   ` Artem Bityutskiy
2009-07-02 15:27   ` Daniel Mack
2009-07-02 15:27     ` Daniel Mack
2009-07-02 15:34     ` Artem Bityutskiy [this message]
2009-07-02 15:34       ` Artem Bityutskiy
2009-07-03  6:48 ` Artem Bityutskiy
2009-07-03  6:48   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246548890.20721.23.camel@localhost.localdomain \
    --to=dedekind@infradead.org \
    --cc=adrian.hunter@nokia.com \
    --cc=daniel@caiaq.de \
    --cc=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.