Re: [LTP] [PATCH] sendfile08: disable this test on kernel less than 2.6.33

Re: [LTP] [PATCH] sendfile08: disable this test on kernel less than 2.6.33

[Jan Stancek]

----- Original Message -----
> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
> To: "LTP" <ltp-list@lists.sourceforge.net>
> Cc: "Cyril Hrubis" <chrubis@suse.cz>, "Caspar Zhang" <caspar@casparzhang.com>, "Garrett Cooper" <yanegomi@gmail.com>,
> "Mike Frysinger" <vapier@gentoo.org>, jstancek@redhat.com, "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
> Sent: Wednesday, 26 June, 2013 3:30:29 AM
> Subject: [PATCH] sendfile08: disable this test on kernel less than 2.6.33
> 
> After kernel commit cc56f7d, sendfile(2) can support any file refered
> "out_fd" instead of only socket.
> Since this test for general file refered "out_fd", so we disable this
> test on the kernel less than 2.6.33.
> 
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Reviewed-by: Jan Stancek <jstancek@redhat.com>

Looks good to me.

Regards,
Jan

> ---
>  testcases/kernel/syscalls/sendfile/sendfile08.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/sendfile/sendfile08.c
> b/testcases/kernel/syscalls/sendfile/sendfile08.c
> index 3d4caa3..748fcd4 100644
> --- a/testcases/kernel/syscalls/sendfile/sendfile08.c
> +++ b/testcases/kernel/syscalls/sendfile/sendfile08.c
> @@ -95,6 +95,13 @@ static void setup(void)
>  {
>  	int ret;
>  
> +	/* Disable test if the version of the kernel is less than 2.6.33 */
> +	if ((tst_kvercmp(2, 6, 33)) < 0) {
> +		tst_resm(TCONF, "The out_fd must refer to a socket before kernel");
> +		tst_resm(TCONF, "2.6.33, see kernel commit cc56f7d");
> +		tst_exit();
> +	}
> +
>  	TEST_PAUSE;
>  
>  	tst_tmpdir();
> --
> 1.8.3.1.448.gfb7dfaa
> 
> 

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] sendfile08: disable this test on kernel less than 2.6.33

[chrubis]

Hi!
> After kernel commit cc56f7d, sendfile(2) can support any file refered
> "out_fd" instead of only socket.
> Since this test for general file refered "out_fd", so we disable this
> test on the kernel less than 2.6.33.
> 
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
>  testcases/kernel/syscalls/sendfile/sendfile08.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/sendfile/sendfile08.c b/testcases/kernel/syscalls/sendfile/sendfile08.c
> index 3d4caa3..748fcd4 100644
> --- a/testcases/kernel/syscalls/sendfile/sendfile08.c
> +++ b/testcases/kernel/syscalls/sendfile/sendfile08.c
> @@ -95,6 +95,13 @@ static void setup(void)
>  {
>  	int ret;
>  
> +	/* Disable test if the version of the kernel is less than 2.6.33 */
> +	if ((tst_kvercmp(2, 6, 33)) < 0) {
> +		tst_resm(TCONF, "The out_fd must refer to a socket before kernel");
> +		tst_resm(TCONF, "2.6.33, see kernel commit cc56f7d");
> +		tst_exit();

Pushed with slightly modified message (so that the line of code fits to
80 chars).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list