All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Caseless UUID comparsion in search command
Date: Mon, 06 Jul 2009 20:38:24 -0400	[thread overview]
Message-ID: <1246927104.31361.43.camel@mj> (raw)
In-Reply-To: <2m2ai6-i7b.ln1@ppp121-45-136-118.lns11.adl6.internode.on.net>

On Tue, 2009-07-07 at 05:46 +0930, Arthur Marsh wrote:
> Daniel Mierswa wrote, on 06/07/09 17:27:
> > Just like some time ago in search_fs_uuid() the search_fs() function of
> > search also needs to be caseless when comparing UUIDs, for some reason
> > GRUB2 didn't find my UUID although I entered it as reported by blkid. To
> > be on the safe side, just use strncasecmp. :) Patch against git master
> > and ChangeLog attached. I await your feedback. :-)
> 
> Thanks, I tried it, but still didn't get any further with the following bug:
> 
> https://savannah.gnu.org/bugs/?26834 search for UUID fails with 
> dedicated /boot filesystem on disk larger than what BIOS sees

That's because ext3 UUID is lower case, so case sensitivity shouldn't be
an issue.

While trying to reproduce the issue, I found and fixed a memory
corruption bug affecting arguments of long options, but your case is not
affected.  You would only be affected it you use "--set=root" instead of
just "--set".

I could not reproduce the problem by setting up a separate partition,
and by instructing qemu to access part of the device.  I don't think
GRUB would fail to find a device by it's UUID if it can load the kernel
from it.  It's more like the UUID from grub.cfg doesn't match the one
GRUB sees.

Please show the output of "ls -l (hd0,1)" on the GRUB command line and
the output of "tune2fs -l /dev/hda1 |grep UUID" in Linux.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2009-07-07  0:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06  7:57 [PATCH] Caseless UUID comparsion in search command Daniel Mierswa
2009-07-06 20:14 ` Pavel Roskin
2009-07-06 20:16 ` Arthur Marsh
2009-07-07  0:38   ` Pavel Roskin [this message]
2009-07-07  1:11     ` Arthur Marsh
2009-07-07  1:43       ` Arthur Marsh
2009-07-07  1:58       ` Pavel Roskin
2009-07-07  3:38         ` Arthur Marsh
2009-07-07  4:23           ` Pavel Roskin
2009-07-07  4:40             ` Arthur Marsh
2009-07-07  6:51               ` Arthur Marsh
2009-07-08  6:26                 ` Pavel Roskin
2009-07-08  8:26                   ` Arthur Marsh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246927104.31361.43.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.