From: Peter Zijlstra <peterz@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [rfc][patch 1/3] fs: new truncate sequence
Date: Tue, 07 Jul 2009 09:29:11 +0200 [thread overview]
Message-ID: <1246951751.8143.104.camel@twins> (raw)
In-Reply-To: <20090706174700.GT2714@wotan.suse.de>
On Mon, 2009-07-06 at 19:47 +0200, Nick Piggin wrote:
> All good points. I don't know what name to use though -- your idea
> of renaming ->truncate then reusing it is nice but people will cry
> about breaking external modules. I'll call it ->setsize and defer
> having to think about it for now.
Changing the function signature should get them a compiler warning,
aside from that I don't think we should really consider their feelings
anyway ;-)
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [rfc][patch 1/3] fs: new truncate sequence
Date: Tue, 07 Jul 2009 09:29:11 +0200 [thread overview]
Message-ID: <1246951751.8143.104.camel@twins> (raw)
In-Reply-To: <20090706174700.GT2714@wotan.suse.de>
On Mon, 2009-07-06 at 19:47 +0200, Nick Piggin wrote:
> All good points. I don't know what name to use though -- your idea
> of renaming ->truncate then reusing it is nice but people will cry
> about breaking external modules. I'll call it ->setsize and defer
> having to think about it for now.
Changing the function signature should get them a compiler warning,
aside from that I don't think we should really consider their feelings
anyway ;-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-07 7:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 16:54 [rfc][patch 1/3] fs: new truncate sequence Nick Piggin
2009-07-06 16:54 ` Nick Piggin
2009-07-06 16:55 ` [rfc][patch 2/3] fs: make use of new helper functions Nick Piggin
2009-07-06 16:55 ` Nick Piggin
2009-07-06 17:23 ` Christoph Hellwig
2009-07-06 17:23 ` Christoph Hellwig
2009-07-06 17:47 ` Nick Piggin
2009-07-06 17:47 ` Nick Piggin
2009-07-06 18:05 ` Miklos Szeredi
2009-07-06 18:05 ` Miklos Szeredi
2009-07-06 16:56 ` [rfc][patch 3/3] fs: convert ext2,tmpfs to new truncate Nick Piggin
2009-07-06 16:56 ` Nick Piggin
2009-07-06 17:28 ` Christoph Hellwig
2009-07-06 17:28 ` Christoph Hellwig
2009-07-06 17:59 ` Nick Piggin
2009-07-06 17:59 ` Nick Piggin
2009-07-07 9:17 ` Nick Piggin
2009-07-07 9:17 ` Nick Piggin
2009-07-07 11:45 ` Boaz Harrosh
2009-07-07 11:45 ` Boaz Harrosh
2009-07-07 13:30 ` Nick Piggin
2009-07-07 13:30 ` Nick Piggin
2009-07-06 17:22 ` [rfc][patch 1/3] fs: new truncate sequence Christoph Hellwig
2009-07-06 17:22 ` Christoph Hellwig
2009-07-06 17:47 ` Nick Piggin
2009-07-06 17:47 ` Nick Piggin
2009-07-07 7:29 ` Peter Zijlstra [this message]
2009-07-07 7:29 ` Peter Zijlstra
2009-07-07 8:48 ` Nick Piggin
2009-07-07 8:48 ` Nick Piggin
2009-07-06 18:00 ` Miklos Szeredi
2009-07-06 18:00 ` Miklos Szeredi
2009-07-06 18:10 ` Nick Piggin
2009-07-06 18:10 ` Nick Piggin
2009-07-07 11:45 ` Boaz Harrosh
2009-07-07 11:45 ` Boaz Harrosh
2009-08-15 14:51 ` Christoph Hellwig
2009-08-15 14:51 ` Christoph Hellwig
2009-08-15 15:14 ` Nick Piggin
2009-08-15 15:14 ` Nick Piggin
2009-08-15 15:18 ` Christoph Hellwig
2009-08-15 15:18 ` Christoph Hellwig
2009-08-15 15:36 ` Nick Piggin
2009-08-15 15:36 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246951751.8143.104.camel@twins \
--to=peterz@infradead.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.