All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Refactor commands/search.c
Date: Tue, 07 Jul 2009 16:14:46 -0400	[thread overview]
Message-ID: <1246997686.3393.33.camel@mj> (raw)
In-Reply-To: <20090707184252.GC14645@thorin>

On Tue, 2009-07-07 at 20:42 +0200, Robert Millan wrote:

> I'd suggest making this clearer by eithe explicitly checking for
> SEARCH_XXX or otherwise put a comment after the else.

Done.  Committed.

-- 
Regards,
Pavel Roskin



      reply	other threads:[~2009-07-07 20:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06 21:13 [PATCH] Refactor commands/search.c Pavel Roskin
2009-07-07  1:03 ` Arthur Marsh
2009-07-07  1:46   ` Arthur Marsh
2009-07-07  2:13     ` Pavel Roskin
2009-07-07  3:00       ` Arthur Marsh
2009-07-07 18:42 ` Robert Millan
2009-07-07 20:14   ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246997686.3393.33.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.