From: Jiri Slaby <jirislaby@gmail.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>
Subject: [PATCH] wireless: wl12xx, fix lock imbalance
Date: Mon, 13 Jul 2009 23:24:26 +0200 [thread overview]
Message-ID: <1247520266-32007-1-git-send-email-jirislaby@gmail.com> (raw)
Add omitted mutex_unlock to one of wl12xx_op_start fail paths (when
wl12xx_chip_wakeup fails).
Not sure if the device should be powered off?
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
drivers/net/wireless/wl12xx/main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 603d611..d241e4a 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -336,7 +336,7 @@ static int wl12xx_op_start(struct ieee80211_hw *hw)
ret = wl12xx_chip_wakeup(wl);
if (ret < 0)
- return ret;
+ goto unlock;
ret = wl->chip.op_boot(wl);
if (ret < 0)
@@ -357,7 +357,7 @@ static int wl12xx_op_start(struct ieee80211_hw *hw)
out:
if (ret < 0)
wl12xx_power_off(wl);
-
+unlock:
mutex_unlock(&wl->mutex);
return ret;
--
1.6.3.2
next reply other threads:[~2009-07-13 21:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 21:24 Jiri Slaby [this message]
2009-07-13 21:40 ` [PATCH] wireless: wl12xx, fix lock imbalance Johannes Berg
2009-07-13 21:44 ` Jiri Slaby
2009-07-13 21:49 ` Jiri Slaby
2009-07-13 21:49 ` Johannes Berg
2009-07-13 21:51 ` Jiri Slaby
2009-07-13 21:54 ` Johannes Berg
2009-07-18 11:19 ` Ingo Molnar
2009-07-18 11:33 ` Johannes Berg
2009-07-18 16:10 ` Ingo Molnar
2009-07-26 8:00 ` stanse [was: wireless: wl12xx, fix lock imbalance] Jiri Slaby
2009-10-12 10:11 ` Stanse 1.0.0 released " Jiri Slaby
2009-10-12 10:11 ` Jiri Slaby
2009-10-12 10:47 ` Stanse 1.0.0 released [was: wireless: wl12xx, fix lock Ingo Molnar
2009-10-12 10:47 ` Stanse 1.0.0 released [was: wireless: wl12xx, fix lock imbalance] Ingo Molnar
2009-07-14 5:44 ` [PATCH] wireless: wl12xx, fix lock imbalance Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247520266-32007-1-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.