Re: [PATCH] osdetect.lua improvement

[Pavel Roskin <proski@gnu.org>]

On Sat, 2009-07-11 at 13:58 +0800, Bean wrote:
> Hi,
> 
> This patch would check for drive number and use drivemap to map disks,
> this is required to boot DOS/Windows from secondary drive. It also
> change commands like root (hd0,0) to root=hd0,0 (I remember someone
> want to remove the root command ?)

Looks good to me.  Actually, the logic should be changed so that we
don't add "chainloader" and "drivemap" for Linux and FreeBSD, but it
could be a separate patch.

What's really needed in osdetect.lua is elimination of partitions with
invalid bootloader signatures.  If the first sector doesn't end with
0x55 0xaa, the partition should not appear with the "chainloader"
command.

For "Other OS", it would be nice to specify the partition in the menu
title.  Actually, maybe we should provide partitions for all names.
Since osdetect.lua scans all drives, it would be nice to distinguish
Linux 2.6.30 that boots Fedora from Linux 2.6.30 that boots SUSE.

-- 
Regards,
Pavel Roskin