From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] unused constants in i386/boot.h
Date: Tue, 14 Jul 2009 14:55:44 -0400 [thread overview]
Message-ID: <1247597744.25012.1.camel@mj> (raw)
In-Reply-To: <20090714173706.GB10523@thorin>
On Tue, 2009-07-14 at 19:37 +0200, Robert Millan wrote:
> On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote:
> > Quoting Yves Blusseau <blusseau@zetam.org>:
> >
> >>> As long as boot/i386/pc/boot.S has the variables whose offset these macros
> >>> are describing, I think it's fine to keep them.
> >
> > I'd rather not keep the macros that are not used outside boot.S. They
> > give a wrong impression that somebody somewhere needs to know that
> > offset.
>
> Ok, let's remove them. I don't feel strongly about it.
I'm working on a patch series that would remove unnecessary stuff and
widen the BPB.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-14 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 8:45 [PATCH] unused constants in i386/boot.h Yves Blusseau
2009-07-10 17:36 ` Robert Millan
2009-07-12 9:02 ` Yves Blusseau
2009-07-12 13:21 ` Pavel Roskin
2009-07-14 17:37 ` Robert Millan
2009-07-14 18:55 ` Pavel Roskin [this message]
2009-07-15 7:36 ` Yves Blusseau
2009-07-15 17:46 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247597744.25012.1.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.