From: Peter Zijlstra <peterz@infradead.org>
To: Matt Helsley <matthltc@us.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rafael Wysocki <rjw@sisk.pl>, Ingo Molnar <mingo@elte.hu>,
Nathan Lynch <ntl@pobox.com>,
Nigel Cunningham <nigel@tuxonice.net>,
stable@kernel.org, containers@lists.linux-foundation.org,
linux-pm@lists.linux-foundation.org
Subject: Re: [patch 2/2] sched: fix nr_uninterruptible accounting of frozen tasks really
Date: Fri, 17 Jul 2009 17:55:27 +0200 [thread overview]
Message-ID: <1247846127.6522.21.camel@laptop> (raw)
In-Reply-To: <20090717155116.GB5878@count0.beaverton.ibm.com>
On Fri, 2009-07-17 at 08:51 -0700, Matt Helsley wrote:
> So it's not clear to me how adding PF_FREEZING fixes anything. Am I
> missing something?
Yep, PF_FROZEN is only observed going into schedule(), on the way back
out thaw_process() will already have cleared the flag.
So we don't increment in deactivate_task(), but we do decrement in
activate_task(), yielding for some very unbalanced accounting.
next prev parent reply other threads:[~2009-07-17 16:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 12:24 [patch 0/2] fix load average accounting Thomas Gleixner
2009-07-17 12:24 ` [patch 1/2] sched: fix load average accounting vs. cpu hotplug Thomas Gleixner
2009-07-17 12:25 ` [patch 2/2] sched: fix nr_uninterruptible accounting of frozen tasks really Thomas Gleixner
2009-07-17 12:25 ` Thomas Gleixner
2009-07-17 12:25 ` Thomas Gleixner
2009-07-17 12:31 ` Peter Zijlstra
2009-07-17 12:31 ` Peter Zijlstra
2009-07-17 12:48 ` Thomas Gleixner
2009-07-17 12:48 ` Thomas Gleixner
2009-07-17 22:26 ` Nigel Cunningham
2009-07-17 22:26 ` Nigel Cunningham
[not found] ` <alpine.LFD.2.00.0907171441020.11571-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-17 22:26 ` Nigel Cunningham
2009-07-17 12:48 ` Thomas Gleixner
2009-07-17 15:22 ` Matt Helsley
2009-07-17 15:22 ` Matt Helsley
[not found] ` <20090717152235.GA5878-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-07-17 16:47 ` Peter Zijlstra
2009-07-17 16:47 ` Peter Zijlstra
2009-07-17 20:55 ` Nathan Lynch
2009-07-17 20:55 ` Nathan Lynch
[not found] ` <1247864134.17553.30.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-18 12:56 ` Peter Zijlstra
2009-07-18 12:56 ` Peter Zijlstra
2009-07-18 23:59 ` Nathan Lynch
2009-07-18 23:59 ` Nathan Lynch
2009-07-18 23:59 ` Nathan Lynch
2009-07-18 12:56 ` Peter Zijlstra
2009-07-17 20:55 ` Nathan Lynch
2009-07-17 16:47 ` Peter Zijlstra
2009-07-17 15:22 ` Matt Helsley
2009-07-17 15:51 ` Matt Helsley
2009-07-17 15:55 ` Peter Zijlstra
2009-07-17 15:55 ` Peter Zijlstra [this message]
2009-07-17 16:20 ` Matt Helsley
2009-07-17 16:20 ` Matt Helsley
2009-07-17 16:20 ` Matt Helsley
[not found] ` <20090717155116.GB5878-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-07-17 15:55 ` Peter Zijlstra
2009-07-17 15:51 ` Matt Helsley
2009-07-17 20:54 ` Nathan Lynch
2009-07-17 20:54 ` Nathan Lynch
[not found] ` <20090717122103.225652146-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2009-07-17 12:31 ` Peter Zijlstra
2009-07-17 15:51 ` Matt Helsley
2009-07-17 20:54 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247846127.6522.21.camel@laptop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=matthltc@us.ibm.com \
--cc=mingo@elte.hu \
--cc=nigel@tuxonice.net \
--cc=ntl@pobox.com \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.