From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] AFS fixes and improvements
Date: Sun, 19 Jul 2009 16:47:36 -0400 [thread overview]
Message-ID: <1248036456.2519.48.camel@mj> (raw)
In-Reply-To: <d7ead6de0907191340x2415c1cbi9c1e27522067c298@mail.gmail.com>
On Sun, 2009-07-19 at 22:40 +0200, Vladimir 'phcoder' Serbinenko wrote:
> > I prefer not to fix minor memory leaks by huge patches. I have a patch,
> > I just wanted to look at the possibility to use grub_kzalloc() and
> > allocating data as part of the partition.
> Well nested partition patch changes the way how partitions are handled
> and fix for memory leak probably wouldn't stay long and will just
> cause an unnecessary rediffing. I prefer to commit a big patch and
> then look if memory leak remains and if it's the case fix the memory
> leak
I think we should release 1.97 first. Sorry, I know that it's bad to
sit on a pile of code, but in my opinion, the nested partition patch is
too intrusive at this point.
I was planning a detailed review of that patch, but I didn't have a
chance.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-19 20:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 19:30 [PATCH] AFS fixes and improvements Vladimir 'phcoder' Serbinenko
2009-07-17 22:35 ` Vladimir 'phcoder' Serbinenko
2009-07-19 5:11 ` Pavel Roskin
2009-07-19 13:20 ` Vladimir 'phcoder' Serbinenko
2009-07-19 15:34 ` Vladimir 'phcoder' Serbinenko
2009-07-19 19:56 ` Pavel Roskin
2009-07-19 20:23 ` Vladimir 'phcoder' Serbinenko
2009-07-19 20:32 ` Pavel Roskin
2009-07-19 20:40 ` Vladimir 'phcoder' Serbinenko
2009-07-19 20:47 ` Pavel Roskin [this message]
2009-07-20 9:36 ` Vladimir 'phcoder' Serbinenko
2009-07-20 18:34 ` Pavel Roskin
2009-07-20 18:56 ` Vladimir 'phcoder' Serbinenko
2009-07-20 19:36 ` Pavel Roskin
2009-07-19 20:10 ` Pavel Roskin
2009-07-19 20:18 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248036456.2519.48.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.