From: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Michael Neuling <mikey-/owAOxkjmzZAfugRpC6u6w@public.gmane.org>
Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2.6.32/stable] CIFS: Remove __exit mark from cifs_init_dns_resolver() header
Date: Tue, 03 Aug 2010 22:40:25 +0100 [thread overview]
Message-ID: <12482.1280871625@redhat.com> (raw)
In-Reply-To: <19826.1280811821-/owAOxkjmzZAfugRpC6u6w@public.gmane.org>
Michael Neuling <mikey-/owAOxkjmzZAfugRpC6u6w@public.gmane.org> wrote:
> An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error
>
> fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver'
>
> This removes the __init from cifs_init_dns_resolver()
That's not really a good idea as the assembler may choose different pieces of
assembly to do variable references and jumps, depending on the section
information.
A better fix is to add:
#include <linux/module.h>
to the header file.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Michael Neuling <mikey@neuling.org>
Cc: dhowells@redhat.com, stable@kernel.org,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH 2.6.32/stable] CIFS: Remove __exit mark from cifs_init_dns_resolver() header
Date: Tue, 03 Aug 2010 22:40:25 +0100 [thread overview]
Message-ID: <12482.1280871625@redhat.com> (raw)
In-Reply-To: <19826.1280811821@neuling.org>
Michael Neuling <mikey@neuling.org> wrote:
> An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error
>
> fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver'
>
> This removes the __init from cifs_init_dns_resolver()
That's not really a good idea as the assembler may choose different pieces of
assembly to do variable references and jumps, depending on the section
information.
A better fix is to add:
#include <linux/module.h>
to the header file.
David
next prev parent reply other threads:[~2010-08-03 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 5:03 [PATCH 2.6.32/stable] CIFS: Remove __exit mark from cifs_exit_dns_resolver() Michael Neuling
2010-08-03 5:03 ` Michael Neuling
2010-08-03 5:03 ` [PATCH 2.6.32/stable] CIFS: Remove __exit mark from cifs_init_dns_resolver() header Michael Neuling
2010-08-03 5:03 ` Michael Neuling
[not found] ` <19826.1280811821-/owAOxkjmzZAfugRpC6u6w@public.gmane.org>
2010-08-03 21:40 ` David Howells [this message]
2010-08-03 21:40 ` David Howells
[not found] ` <12482.1280871625-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-08-03 22:32 ` [PATCH 2.6.32/stable] CIFS: Fix compile error with __init in cifs_init_dns_resolver() definition Michael Neuling
2010-08-03 22:32 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12482.1280871625@redhat.com \
--to=dhowells-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mikey-/owAOxkjmzZAfugRpC6u6w@public.gmane.org \
--cc=stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.