From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Check for the appropriate condition in types.h
Date: Thu, 23 Jul 2009 10:37:31 -0400 [thread overview]
Message-ID: <1248359851.7855.2.camel@mj> (raw)
In-Reply-To: <1248347411.4660.81.camel@accesodirecto.casa>
On Thu, 2009-07-23 at 13:10 +0200, Javier Martín wrote:
> Currently <grub/types.h> verifies that sizeof(void*)==sizeof(long) and
> then proceeds to define most fixed-length types based on sizeof(void*).
> While simplification seems a good idea on paper, it is always good
> practice to check specifically for what we want to know. In particular,
> the assumption that long can hold a pointer will go down when (if)
> mingw64 support is merged, because Win64 follows the LLP64 model instead
> of the LP64 *nix model.
>
> Given that currently both values are, by precondition, the same, this
> change is guaranteed not to create any problems, while it might avoid
> them in the future.
The patch is good. Please include the ChangeLog entry.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-23 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 11:10 [PATCH] Check for the appropriate condition in types.h Javier Martín
2009-07-23 14:37 ` Pavel Roskin [this message]
2009-07-23 15:30 ` Javier Martín
2009-07-23 15:40 ` Vladimir 'phcoder' Serbinenko
2009-07-23 18:11 ` Javier Martín
2009-07-23 19:51 ` Pavel Roskin
2009-07-23 20:30 ` Vladimir 'phcoder' Serbinenko
2009-07-23 20:57 ` Pavel Roskin
2009-07-25 21:02 ` Javier Martín
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248359851.7855.2.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.