Re: Fwd: [PATCH 1/2] Framebuffer split

[Pavel Roskin <proski@gnu.org>]

On Thu, 2009-07-23 at 11:52 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello. Here is a framebuffer split which has already been discussed.
> This patch contains some code by Collin D Bennett in addition to my
> code. Sorry for compression but maillist server doesn't accept it otherwise

Please include an uncompressed ChangeLog entry.  Even though the issue
was discussed, it would help if you include a description of the changes
to simplify reviewing.  You can copy a previously posted description.

grub_video_vbe_set_viewport and grub_video_vbe_get_info_and_fini need to
be declared static to avoid compiler warnings.

Apart from that, no warnings are introduced.

Please don't add trailing whitespace.  Since you are using git, you can
easily check it with STGit by running "stg edit -d".

grub_video_vbe_get_info_and_fini strikes as a weird name.  The comment
says:

/* Get information about active video mode.  */

Likewise, all occurrences of "get_info_and_fini" should probably be
replaced with something more descriptive.

-- 
Regards,
Pavel Roskin