From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 2/2] SDL support
Date: Thu, 23 Jul 2009 20:19:24 -0400 [thread overview]
Message-ID: <1248394764.2661.248.camel@mj> (raw)
In-Reply-To: <d7ead6de0907231344j79b7a085o5683c05c142537b8@mail.gmail.com>
On Thu, 2009-07-23 at 22:44 +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Thu, Jul 23, 2009 at 10:32 PM, Pavel Roskin<proski@gnu.org> wrote:
> > On Thu, 2009-07-23 at 11:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
> >> Hello. Here is already-discussed SDL support
> >
> > The patch refers to video/fb/video_fb.c, which is not included.
> Well it's PATCH 2/2 and PATCH 1/2 is framebuffer split which is the
> pre-requisite for this patch. I had some problems with sending but now
> I checked the archives and see that the patch 1 successfully arrived
Sorry, I missed that.
When testing the patches together, there is a warning in
grub_video_sdl_enable_double_buffering(). The "enable" argument should
be marked as unused.
Also, when compiling on PowerPC, configure reports that SDL is enabled,
but it is not. The same applies to USB support.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-24 0:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 9:49 [PATCH 2/2] SDL support Vladimir 'phcoder' Serbinenko
2009-07-23 20:32 ` Pavel Roskin
2009-07-23 20:44 ` Vladimir 'phcoder' Serbinenko
2009-07-24 0:19 ` Pavel Roskin [this message]
2009-07-25 16:26 ` Robert Millan
2009-07-25 21:54 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248394764.2661.248.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.