From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 2/2] SDL support
Date: Thu, 23 Jul 2009 16:32:09 -0400 [thread overview]
Message-ID: <1248381129.2661.79.camel@mj> (raw)
In-Reply-To: <d7ead6de0907230249g1662f38dv9d2e9cfd16016b88@mail.gmail.com>
On Thu, 2009-07-23 at 11:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello. Here is already-discussed SDL support
The patch refers to video/fb/video_fb.c, which is not included.
Also, please check the changes I made to your changes to configure.ac.
Please check the spelling of "explicitly". There is no need for verbose
excuses, it's enough to say "need SDL library" or "need SDL headers".
"build and install the `grub-emu' debugging utility with SDL support" is
also too long and not quite correct. --enable-grub-emu-sdl decides
whether SDL support will be in grub-emu. Since it's the default, maybe
it's better to describe --disable-grub-emu-sdl. Obviously, it applies
to grub-emu-usb as well, I just didn't have a chance to clean it up.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-23 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 9:49 [PATCH 2/2] SDL support Vladimir 'phcoder' Serbinenko
2009-07-23 20:32 ` Pavel Roskin [this message]
2009-07-23 20:44 ` Vladimir 'phcoder' Serbinenko
2009-07-24 0:19 ` Pavel Roskin
2009-07-25 16:26 ` Robert Millan
2009-07-25 21:54 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248381129.2661.79.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.