From: Alex Vandiver <alex@chmrr.net>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] After renaming a section, print any trailing variable definitions
Date: Fri, 24 Jul 2009 18:26:55 -0400 [thread overview]
Message-ID: <1248474081-sup-2762@utwig> (raw)
In-Reply-To: <20090725071105.6117@nanako3.lavabit.com>
At Fri Jul 24 18:11:05 -0400 2009, Nanako Shiraishi wrote:
> Quoting Alex Vandiver <alex@chmrr.net>
> > diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
> > index 43ea283..8c43dcd 100755
> > --- a/t/t1300-repo-config.sh
> > +++ b/t/t1300-repo-config.sh
> > @@ -460,6 +460,28 @@ EOF
> > test_expect_success "rename succeeded" "test_cmp expect .git/config"
> >
> > cat >> .git/config << EOF
> > +[branch "vier"] z = 1
> > +EOF
>
> Isn't this a syntax error?
Nope -- at least, not according to both the code, and the tests
(search or noNewline in t/t1300-repo-config.sh).
Though I also note that the documentation disagrees with the code in
the following case:
Each variable must belong to some section, which means that there
must be a section header before the first setting of a variable.
$ cat >bogus
foo = 42
$ git config --file bogus --list
foo=42
$ git config --file bogus --get foo
42
- Alex
--
Networking -- only one letter away from not working
next prev parent reply other threads:[~2009-07-24 22:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 21:21 [PATCH 0/2] Section renaming can lose content Alex Vandiver
2009-07-24 21:21 ` [PATCH 1/2] Make section_name_match start on '[', and return the length on success Alex Vandiver
2009-07-24 21:21 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Alex Vandiver
2009-07-24 22:11 ` Nanako Shiraishi
2009-07-24 22:26 ` Alex Vandiver [this message]
2009-07-26 16:18 ` [PATCH] Make git config fail on variables with no section, as documented Alex Vandiver
2009-07-26 16:49 ` Johannes Schindelin
2009-07-26 19:32 ` Alex Vandiver
2009-07-26 19:48 ` Johannes Schindelin
2009-07-26 20:24 ` Alex Vandiver
2009-07-24 23:39 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Junio C Hamano
2009-07-25 0:28 ` (unknown), Nanako Shiraishi
2009-07-25 14:10 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Johannes Schindelin
2009-07-25 14:09 ` [PATCH 1/2] Make section_name_match start on '[', and return the length on success Johannes Schindelin
2009-07-25 17:18 ` Alex Vandiver
2009-07-25 17:39 ` Junio C Hamano
2009-07-25 17:41 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248474081-sup-2762@utwig \
--to=alex@chmrr.net \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.