From: Alex Vandiver <alex@chmrr.net>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] Make section_name_match start on '[', and return the length on success
Date: Sat, 25 Jul 2009 13:18:52 -0400 [thread overview]
Message-ID: <1248542170-sup-4264@utwig> (raw)
In-Reply-To: <alpine.DEB.1.00.0907251605240.8306@pacific.mpi-cbg.de>
At Sat Jul 25 10:09:56 -0400 2009, Johannes Schindelin wrote:
> Is this not unnecessary, given that we only call that function when we
> know that buf[0] == '[':
Yes. However, given that I had changed the calling convention for the
code, (it used to be passed the string starting just _inside_ the
'['), I wanted to make the new calling convention clearer, and catch
any places that were using the old convention.
I'm happy to submit a new version without it, if you wish.
> I was a bit surprised that "offset" is not used further in your patch, but
> I saw that 2/2 uses it.
Yeah, this hunk should probably have gone in 2/2 instead.
- Alex
--
Networking -- only one letter away from not working
next prev parent reply other threads:[~2009-07-25 17:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 21:21 [PATCH 0/2] Section renaming can lose content Alex Vandiver
2009-07-24 21:21 ` [PATCH 1/2] Make section_name_match start on '[', and return the length on success Alex Vandiver
2009-07-24 21:21 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Alex Vandiver
2009-07-24 22:11 ` Nanako Shiraishi
2009-07-24 22:26 ` Alex Vandiver
2009-07-26 16:18 ` [PATCH] Make git config fail on variables with no section, as documented Alex Vandiver
2009-07-26 16:49 ` Johannes Schindelin
2009-07-26 19:32 ` Alex Vandiver
2009-07-26 19:48 ` Johannes Schindelin
2009-07-26 20:24 ` Alex Vandiver
2009-07-24 23:39 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Junio C Hamano
2009-07-25 0:28 ` (unknown), Nanako Shiraishi
2009-07-25 14:10 ` [PATCH 2/2] After renaming a section, print any trailing variable definitions Johannes Schindelin
2009-07-25 14:09 ` [PATCH 1/2] Make section_name_match start on '[', and return the length on success Johannes Schindelin
2009-07-25 17:18 ` Alex Vandiver [this message]
2009-07-25 17:39 ` Junio C Hamano
2009-07-25 17:41 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248542170-sup-4264@utwig \
--to=alex@chmrr.net \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.