From: Fabian Deutsch <fabian.deutsch@gmx.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: hail-devel@vger.kernel.org
Subject: Re: Regarding 2a5e626aa6e08d894e74af053236947cced8ff87
Date: Sat, 25 Jul 2009 11:53:19 +0200 [thread overview]
Message-ID: <1248515599.4587.1.camel@decade.local> (raw)
In-Reply-To: <4A6A6747.8020007@garzik.org>
Am Freitag, den 24.07.2009, 22:00 -0400 schrieb Jeff Garzik:
> Fabian Deutsch wrote:
> > Am Donnerstag, den 23.07.2009, 14:10 -0400 schrieb Jeff Garzik:
> >> Fabian Deutsch wrote:
> >>>>> Regarding the aboved mentioned commit, I'd suggest using
> >>>>>
> >>>>> #define CLD_DEF_DATADIR "/tmp/cld/lib"
> >>>>>
> >>>>> instead of
> >>>>>
> >>>>> #define CLD_DEF_DATADIR "/spare/tmp/cld/lib"
> >>>>>
> >>>>> as /tmp seems to be more present than /spare.
> >>>> True, though ideally someone should go through Fedora and autotools, and
> >>>> figure out the proper location -- most likely somewhere in /var. You
> >>>> never want permanent data in /tmp, either. :)
> >>> Yeah, reboots might have surprising effects :)
> >>> Maybe something like the attached patch: Using autools vars to determin
> >>> some paths ..
> >> Your patch is heading in the right direction, but I have a few comments...
> >>
> >> * IIRC, AC_DEFINE() macro in configure.ac is the right place to define
> >> this sort of thing
> >
> > I've followed the recommended way mentioned here:
> > http://www.gnu.org/software/autoconf/manual/html_node/Installation-Directory-Variables.html#Installation-Directory-Variables
> >
> > AC_DEFINE shall not be used per se ...
>
> Well, I disagree [with GNU], but it's a standard, so we'll go this way...
So, you two pence, why AC_DEFINE would be a betterw ay?
- fabian
next parent reply other threads:[~2009-07-25 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1248353811.4605.9.camel@decade.local>
[not found] ` <4A689245.5000204@garzik.org>
[not found] ` <1248370729.7812.1.camel@localhost.localdomain>
[not found] ` <4A68A7A3.4050606@garzik.org>
[not found] ` <1248443457.2444.13.camel@localhost.localdomain>
[not found] ` <4A6A6747.8020007@garzik.org>
2009-07-25 9:53 ` Fabian Deutsch [this message]
2009-07-25 19:37 ` Regarding 2a5e626aa6e08d894e74af053236947cced8ff87 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248515599.4587.1.camel@decade.local \
--to=fabian.deutsch@gmx.de \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.