From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: Make it easier to catch NULL cache names
Date: Tue, 28 Jul 2009 17:39:10 +1000 [thread overview]
Message-ID: <1248766750.30993.51.camel@pasglop> (raw)
In-Reply-To: <alpine.DEB.2.00.0907272200520.22207@chino.kir.corp.google.com>
On Mon, 2009-07-27 at 22:01 -0700, David Rientjes wrote:
> On Tue, 28 Jul 2009, Benjamin Herrenschmidt wrote:
>
> > > Please don't do BUG_ON() when there are alternatives.
> > >
> > > In this case, something like
> > >
> > > if (WARN_ON(!name))
> > > return NULL;
> > >
> > > would probably have worked too.
> >
> > Fair enough.. I'll send a new patch.
> >
>
> Actually needs goto err, not return NULL, to appropriately panic when
> SLAB_PANIC is set.
Rats ! Why is it the trivial ones that are sooo hard :-)
New patch will have to wait til tomorrow, on my way home now.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: Make it easier to catch NULL cache names
Date: Tue, 28 Jul 2009 17:39:10 +1000 [thread overview]
Message-ID: <1248766750.30993.51.camel@pasglop> (raw)
In-Reply-To: <alpine.DEB.2.00.0907272200520.22207@chino.kir.corp.google.com>
On Mon, 2009-07-27 at 22:01 -0700, David Rientjes wrote:
> On Tue, 28 Jul 2009, Benjamin Herrenschmidt wrote:
>
> > > Please don't do BUG_ON() when there are alternatives.
> > >
> > > In this case, something like
> > >
> > > if (WARN_ON(!name))
> > > return NULL;
> > >
> > > would probably have worked too.
> >
> > Fair enough.. I'll send a new patch.
> >
>
> Actually needs goto err, not return NULL, to appropriately panic when
> SLAB_PANIC is set.
Rats ! Why is it the trivial ones that are sooo hard :-)
New patch will have to wait til tomorrow, on my way home now.
Cheers,
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-28 7:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 1:48 [PATCH] mm: Make it easier to catch NULL cache names Benjamin Herrenschmidt
2009-07-28 1:48 ` Benjamin Herrenschmidt
2009-07-28 2:52 ` Linus Torvalds
2009-07-28 2:52 ` Linus Torvalds
2009-07-28 2:55 ` Benjamin Herrenschmidt
2009-07-28 2:55 ` Benjamin Herrenschmidt
2009-07-28 5:01 ` David Rientjes
2009-07-28 5:01 ` David Rientjes
2009-07-28 7:39 ` Benjamin Herrenschmidt [this message]
2009-07-28 7:39 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-07-28 4:11 Benjamin Herrenschmidt
2009-07-28 4:11 ` Benjamin Herrenschmidt
2009-07-29 0:06 ` Andrew Morton
2009-07-29 0:06 ` Andrew Morton
2009-07-29 5:55 ` Benjamin Herrenschmidt
2009-07-29 5:55 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248766750.30993.51.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.