From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] gfxterm clear_char
Date: Wed, 29 Jul 2009 18:15:45 -0400 [thread overview]
Message-ID: <1248905745.4253.14.camel@mj> (raw)
In-Reply-To: <DCE5739C-39C0-455F-8BEB-FC6A5FE4F42D@gmail.com>
On Tue, 2009-07-28 at 22:15 -0700, Joe Auricchio wrote:
> Eine kleine gfxterm.c cleanup
Applied with formatting changes.
> static void
> +clear_char(struct grub_colored_char *c)
Space is needed before the parenthesis.
> +{
> + c->code = ' ';
Indentation should be 2 spaces, not 4.
> for(i = 0; i < virtual_screen.columns * virtual_screen.rows; i++)
> {
This brace is no longer needed.
> Index: src/ChangeLog
It would be more convenient if the ChangeLog entry is posted inline
rather than inside the patch.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2009-07-29 22:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 5:15 [PATCH] gfxterm clear_char Joe Auricchio
2009-07-29 22:15 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248905745.4253.14.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.