From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
Date: Thu, 16 Apr 2020 18:24:29 +0100 [thread overview]
Message-ID: <1248b9b0922a2c2886650f5bacadf1af@kernel.org> (raw)
In-Reply-To: <20200416170539.GC32685@willie-the-truck>
On 2020-04-16 18:05, Will Deacon wrote:
> On Thu, Apr 16, 2020 at 04:36:05PM +0100, Marc Zyngier wrote:
>> On Wed, 15 Apr 2020 18:57:46 +0800
>> Zenghui Yu <yuzenghui@huawei.com> wrote:
>>
>> > The only user of PTE_S2_MEMATTR_MASK macro had been removed since
>> > commit a501e32430d4 ("arm64: Clean up the default pgprot setting").
>> > It has been about six years and no one has used it again.
>> >
>> > Let's drop it.
>> >
>> > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
>> > ---
>> > arch/arm64/include/asm/pgtable-hwdef.h | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
>> > index 6bf5e650da78..99315bdca0e6 100644
>> > --- a/arch/arm64/include/asm/pgtable-hwdef.h
>> > +++ b/arch/arm64/include/asm/pgtable-hwdef.h
>> > @@ -190,7 +190,6 @@
>> > * Memory Attribute override for Stage-2 (MemAttr[3:0])
>> > */
>> > #define PTE_S2_MEMATTR(t) (_AT(pteval_t, (t)) << 2)
>> > -#define PTE_S2_MEMATTR_MASK (_AT(pteval_t, 0xf) << 2)
>> >
>> > /*
>> > * EL2/HYP PTE/PMD definitions
>>
>> Looks good to me. Catalin, Will: do you want to take this directly? If
>> so please add my:
>>
>> Acked-by: Marc Zyngier <maz@kernel.org>
>>
>> Otherwise, I'll route it via the KVM tree.
>
> I can take it for 5.8 if it's not urgent.
It has been there 6 years, I think we can cope with another few
months... ;-)
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
Zenghui Yu <yuzenghui@huawei.com>,
wanghaibin.wang@huawei.com, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
Date: Thu, 16 Apr 2020 18:24:29 +0100 [thread overview]
Message-ID: <1248b9b0922a2c2886650f5bacadf1af@kernel.org> (raw)
In-Reply-To: <20200416170539.GC32685@willie-the-truck>
On 2020-04-16 18:05, Will Deacon wrote:
> On Thu, Apr 16, 2020 at 04:36:05PM +0100, Marc Zyngier wrote:
>> On Wed, 15 Apr 2020 18:57:46 +0800
>> Zenghui Yu <yuzenghui@huawei.com> wrote:
>>
>> > The only user of PTE_S2_MEMATTR_MASK macro had been removed since
>> > commit a501e32430d4 ("arm64: Clean up the default pgprot setting").
>> > It has been about six years and no one has used it again.
>> >
>> > Let's drop it.
>> >
>> > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
>> > ---
>> > arch/arm64/include/asm/pgtable-hwdef.h | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
>> > index 6bf5e650da78..99315bdca0e6 100644
>> > --- a/arch/arm64/include/asm/pgtable-hwdef.h
>> > +++ b/arch/arm64/include/asm/pgtable-hwdef.h
>> > @@ -190,7 +190,6 @@
>> > * Memory Attribute override for Stage-2 (MemAttr[3:0])
>> > */
>> > #define PTE_S2_MEMATTR(t) (_AT(pteval_t, (t)) << 2)
>> > -#define PTE_S2_MEMATTR_MASK (_AT(pteval_t, 0xf) << 2)
>> >
>> > /*
>> > * EL2/HYP PTE/PMD definitions
>>
>> Looks good to me. Catalin, Will: do you want to take this directly? If
>> so please add my:
>>
>> Acked-by: Marc Zyngier <maz@kernel.org>
>>
>> Otherwise, I'll route it via the KVM tree.
>
> I can take it for 5.8 if it's not urgent.
It has been there 6 years, I think we can cope with another few
months... ;-)
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Zenghui Yu <yuzenghui@huawei.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
Date: Thu, 16 Apr 2020 18:24:29 +0100 [thread overview]
Message-ID: <1248b9b0922a2c2886650f5bacadf1af@kernel.org> (raw)
In-Reply-To: <20200416170539.GC32685@willie-the-truck>
On 2020-04-16 18:05, Will Deacon wrote:
> On Thu, Apr 16, 2020 at 04:36:05PM +0100, Marc Zyngier wrote:
>> On Wed, 15 Apr 2020 18:57:46 +0800
>> Zenghui Yu <yuzenghui@huawei.com> wrote:
>>
>> > The only user of PTE_S2_MEMATTR_MASK macro had been removed since
>> > commit a501e32430d4 ("arm64: Clean up the default pgprot setting").
>> > It has been about six years and no one has used it again.
>> >
>> > Let's drop it.
>> >
>> > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
>> > ---
>> > arch/arm64/include/asm/pgtable-hwdef.h | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
>> > index 6bf5e650da78..99315bdca0e6 100644
>> > --- a/arch/arm64/include/asm/pgtable-hwdef.h
>> > +++ b/arch/arm64/include/asm/pgtable-hwdef.h
>> > @@ -190,7 +190,6 @@
>> > * Memory Attribute override for Stage-2 (MemAttr[3:0])
>> > */
>> > #define PTE_S2_MEMATTR(t) (_AT(pteval_t, (t)) << 2)
>> > -#define PTE_S2_MEMATTR_MASK (_AT(pteval_t, 0xf) << 2)
>> >
>> > /*
>> > * EL2/HYP PTE/PMD definitions
>>
>> Looks good to me. Catalin, Will: do you want to take this directly? If
>> so please add my:
>>
>> Acked-by: Marc Zyngier <maz@kernel.org>
>>
>> Otherwise, I'll route it via the KVM tree.
>
> I can take it for 5.8 if it's not urgent.
It has been there 6 years, I think we can cope with another few
months... ;-)
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-04-16 17:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 10:57 [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK Zenghui Yu
2020-04-15 10:57 ` Zenghui Yu
2020-04-15 10:57 ` Zenghui Yu
2020-04-16 15:36 ` Marc Zyngier
2020-04-16 15:36 ` Marc Zyngier
2020-04-16 15:36 ` Marc Zyngier
2020-04-16 17:05 ` Will Deacon
2020-04-16 17:05 ` Will Deacon
2020-04-16 17:05 ` Will Deacon
2020-04-16 17:24 ` Marc Zyngier [this message]
2020-04-16 17:24 ` Marc Zyngier
2020-04-16 17:24 ` Marc Zyngier
2020-04-28 14:49 ` Will Deacon
2020-04-28 14:49 ` Will Deacon
2020-04-28 14:49 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248b9b0922a2c2886650f5bacadf1af@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.