From: Pavel Roskin <proski@gnu.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 08/24] ath9k: pass only one argument to hw attach
Date: Mon, 03 Aug 2009 15:58:23 -0400 [thread overview]
Message-ID: <1249329503.5652.9.camel@mj> (raw)
In-Reply-To: <1249328027-24865-1-git-send-email-lrodriguez@atheros.com>
On Mon, 2009-08-03 at 12:33 -0700, Luis R. Rodriguez wrote:
> The softc is cached and set within the ath_hw struct.
That's not meant to criticize this particular patch, but what's the
point in distinguishing sc from ah these days? I believe "ah" used to
refer to the closed part of the sc structure that was only touched by
Atheros HAL, hence the name.
Since there is no HAL anymore, ah should disappear.
As the first step, ah should be allocated as part of sc. Then ah and sc
should stop pointing to each other. Instead, macros based on offsetof
should be used. Then ah should be dissolved and replaced with sc
throughout the code.
That's probably a good task for an aspiring kernel hacker, as it
requires little specialized knowledge.
--
Regards,
Pavel Roskin
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Roskin <proski@gnu.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
Subject: Re: [ath9k-devel] [PATCH 08/24] ath9k: pass only one argument to hw attach
Date: Mon, 03 Aug 2009 15:58:23 -0400 [thread overview]
Message-ID: <1249329503.5652.9.camel@mj> (raw)
In-Reply-To: <1249328027-24865-1-git-send-email-lrodriguez@atheros.com>
On Mon, 2009-08-03 at 12:33 -0700, Luis R. Rodriguez wrote:
> The softc is cached and set within the ath_hw struct.
That's not meant to criticize this particular patch, but what's the
point in distinguishing sc from ah these days? I believe "ah" used to
refer to the closed part of the sc structure that was only touched by
Atheros HAL, hence the name.
Since there is no HAL anymore, ah should disappear.
As the first step, ah should be allocated as part of sc. Then ah and sc
should stop pointing to each other. Instead, macros based on offsetof
should be used. Then ah should be dissolved and replaced with sc
throughout the code.
That's probably a good task for an aspiring kernel hacker, as it
requires little specialized knowledge.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-08-03 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 19:33 [ath9k-devel] [PATCH 08/24] ath9k: pass only one argument to hw attach Luis R. Rodriguez
2009-08-03 19:33 ` Luis R. Rodriguez
2009-08-03 19:58 ` Pavel Roskin [this message]
2009-08-03 19:58 ` [ath9k-devel] " Pavel Roskin
2009-08-03 20:28 ` Luis R. Rodriguez
2009-08-03 20:28 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2009-08-03 19:24 [ath9k-devel] [PATCH 00/24] ath9k: hw initiazliation cleanup Luis R. Rodriguez
2009-08-03 19:24 ` [ath9k-devel] [PATCH 08/24] ath9k: pass only one argument to hw attach Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249329503.5652.9.camel@mj \
--to=proski@gnu.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.