From: Tony Vroon <tony@linx.net>
To: Chetan.Loke@Emulex.Com
Cc: hancockrwd@gmail.com, jgarzik@pobox.com,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
philipl@overt.org
Subject: RE: [PATCH 2.6.32 v2] MCP55 SATA2 conditional MSI support for sata_nv
Date: Thu, 06 Aug 2009 16:59:23 +0100 [thread overview]
Message-ID: <1249574363.4530.23.camel@localhost> (raw)
In-Reply-To: <412A05BA40734D4887DBC67661F433080D73228B@EXMAIL.ad.emulex.com>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
> disable_msi() is missing right?
I didn't add that as none of the other drivers have it:
chainsaw@amalthea /cvs/linux-2.6/drivers/ata $ grep _msi * | grep pci
ahci.c: pci_enable_msi(pdev);
sata_mv.c: if (msi && pci_enable_msi(pdev) == 0)
sata_vsc.c: if (pci_enable_msi(pdev) == 0)
(This is a tree without the sata_nv change I submitted)
I do believe it is safe to shut the interrupt down and unload the
handler whilst it is still in MSI mode. At least, I don't see the libata
core special-casing it in any way.
> Chetan
Regards,
Tony V.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-08-06 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 19:20 [PATCH 2.6.32 v2] MCP55 SATA2 conditional MSI support for sata_nv Tony Vroon
2009-08-05 23:33 ` Robert Hancock
2009-08-06 15:41 ` Chetan.Loke
2009-08-06 15:41 ` Chetan.Loke
2009-08-06 15:59 ` Tony Vroon [this message]
2009-08-06 16:28 ` Chetan.Loke
2009-08-06 16:28 ` Chetan.Loke
2009-08-06 23:11 ` Robert Hancock
2009-08-06 23:26 ` Tejun Heo
2009-08-06 23:57 ` Tony Vroon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249574363.4530.23.camel@localhost \
--to=tony@linx.net \
--cc=Chetan.Loke@Emulex.Com \
--cc=hancockrwd@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipl@overt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.