All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: Chetan.Loke@Emulex.Com, tony@linx.net, jgarzik@pobox.com,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	philipl@overt.org
Subject: Re: [PATCH 2.6.32 v2] MCP55 SATA2 conditional MSI support for sata_nv
Date: Fri, 07 Aug 2009 08:26:58 +0900	[thread overview]
Message-ID: <4A7B66C2.3060207@kernel.org> (raw)
In-Reply-To: <4A7B633C.3040500@gmail.com>

Robert Hancock wrote:
>> If I'm not wrong then that's how it's supposed to be done. free_irq
>> and then disable_msi. You can't reverse the order. Also the driver
>> should know when to quiesce the ASIC. So quiesce first and then
>> shutdown everything.
> 
> Seems like devres should handle this somehow, or else something in
> libata core.. Tejun?

Yeah, if the device was enabled with pcim_enable_device(), devres will
take of all the cleanups.  No need to worry about them.

Thanks.

-- 
tejun

  reply	other threads:[~2009-08-06 23:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 19:20 [PATCH 2.6.32 v2] MCP55 SATA2 conditional MSI support for sata_nv Tony Vroon
2009-08-05 23:33 ` Robert Hancock
2009-08-06 15:41   ` Chetan.Loke
2009-08-06 15:41     ` Chetan.Loke
2009-08-06 15:59     ` Tony Vroon
2009-08-06 16:28       ` Chetan.Loke
2009-08-06 16:28         ` Chetan.Loke
2009-08-06 23:11         ` Robert Hancock
2009-08-06 23:26           ` Tejun Heo [this message]
2009-08-06 23:57             ` Tony Vroon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7B66C2.3060207@kernel.org \
    --to=tj@kernel.org \
    --cc=Chetan.Loke@Emulex.Com \
    --cc=hancockrwd@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipl@overt.org \
    --cc=tony@linx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.