From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 6/18] define asm constant for absolute memory access
Date: Thu, 13 Aug 2009 01:03:34 -0400 [thread overview]
Message-ID: <1250139814.2352.3.camel@ct> (raw)
In-Reply-To: <d7ead6de0906160349s11d09e62pe16a5b1f644a4f76@mail.gmail.com>
On Tue, 2009-06-16 at 12:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
> > +#ifdef APPLE_CC
> > + movl $(mmaphook_mmap_rel), %esi
> > +#else
> > movw $(DS(mmaphook_mmap)), %si
> > +#endif
>
> That's not an equivalent replacement. The argument width is
> different.
> I know. Sometimes because of the quirks I had to replace some code
> with a less logical alternative which should however work in the flow
Please don't commit such changes without an explicit permissions form
the maintainers. It's very time consuming to verify such code after it
has been committed.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2009-08-13 5:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 14:46 [PATCH 6/18] define asm constant for absolute memory access Vladimir 'phcoder' Serbinenko
2009-06-16 1:28 ` Pavel Roskin
2009-06-16 10:49 ` Vladimir 'phcoder' Serbinenko
2009-08-13 5:03 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250139814.2352.3.camel@ct \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.