From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] RFT: Rename local labels with a macro from boot/i386/pc/boot.S
Date: Thu, 13 Aug 2009 02:13:32 -0400 [thread overview]
Message-ID: <1250144012.2352.35.camel@ct> (raw)
In-Reply-To: <20090810112941.GB9344@thorin>
On Mon, 2009-08-10 at 13:29 +0200, Robert Millan wrote:
> On Sat, Aug 08, 2009 at 04:48:32PM +0200, Yves Blusseau wrote:
> > diff --git a/include/grub/symbol.h b/include/grub/symbol.h
> > index 68d9f00..5fba549 100644
> > --- a/include/grub/symbol.h
> > +++ b/include/grub/symbol.h
> > @@ -21,6 +21,8 @@
> >
> > #include <config.h>
> >
> > +#define LOCAL(X) L_##X
> > +
> > /* Add an underscore to a C symbol in assembler code if needed. */
> > #ifdef HAVE_ASM_USCORE
> > # define EXT_C(sym) _ ## sym
I changed LOCAL to be more similar to EXT_C (macro arguments don't
normally use capital letters). I also added a comment, as there is no
other way to know why we are adding "L_" to the labels.
> Assuming Pavel is OK with it, I have no objection.
Committed. Thank you!
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2009-08-13 6:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 3:47 [PATCH 1/2] RFT: Eliminate Apple specific code from boot/i386/pc/boot.S Pavel Roskin
2009-07-16 3:47 ` [PATCH 2/2] RFT: Remove ABS macro " Pavel Roskin
2009-07-18 15:17 ` Vladimir 'phcoder' Serbinenko
2009-07-18 18:22 ` Robert Millan
2009-07-18 18:34 ` Vladimir 'phcoder' Serbinenko
2009-07-18 19:16 ` Robert Millan
2009-08-07 17:15 ` Vladimir 'phcoder' Serbinenko
2009-08-13 5:53 ` Pavel Roskin
2009-07-16 16:31 ` [PATCH 1/2] RFT: Eliminate Apple specific code " Vladimir 'phcoder' Serbinenko
2009-08-13 5:21 ` Pavel Roskin
2009-08-08 14:48 ` [PATCH] RFT: Rename local labels with a macro " Yves Blusseau
2009-08-08 14:55 ` Vladimir 'phcoder' Serbinenko
2009-08-08 15:47 ` Yves Blusseau
2009-08-10 11:29 ` Robert Millan
2009-08-13 6:13 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250144012.2352.35.camel@ct \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.