From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] GFS2: Pull request (fixes)
Date: Fri, 14 Aug 2009 14:01:34 +0100 [thread overview]
Message-ID: <1250254894.3298.204.camel@localhost.localdomain> (raw)
Hi,
Please consider pulling the following fix,
Steve.
------------------------------------------------------------------------
The following changes since commit 64f1607ffbbc772685733ea63e6f7f4183df1b16:
Linus Torvalds (1):
Linux 2.6.31-rc6
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-fixes.git master
Steven Whitehouse (1):
GFS2: Fix permissions on "recover" file
fs/gfs2/sys.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
---------------------------------------------------------------------------
From d7e623da1a757fbd8c117fa29190ca8bef14dab3 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Tue, 11 Aug 2009 11:20:11 +0100
Subject: [PATCH] GFS2: Fix permissions on "recover" file
Although this file is only ever written and not read by
userspace, it seems that the utils are opening this
file O_RDWR, so we need to allow that.
Also fixes the whitespace which seemed to be broken.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Cc: David Teigland <teigland@redhat.com>
---
fs/gfs2/sys.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
index 23419dc..a7cbfbd 100644
--- a/fs/gfs2/sys.c
+++ b/fs/gfs2/sys.c
@@ -386,16 +386,16 @@ static ssize_t jid_show(struct gfs2_sbd *sdp, char *buf)
#define GDLM_ATTR(_name,_mode,_show,_store) \
static struct gfs2_attr gdlm_attr_##_name = __ATTR(_name,_mode,_show,_store)
-GDLM_ATTR(proto_name, 0444, proto_name_show, NULL);
-GDLM_ATTR(block, 0644, block_show, block_store);
-GDLM_ATTR(withdraw, 0644, withdraw_show, withdraw_store);
-GDLM_ATTR(id, 0444, lkid_show, NULL);
-GDLM_ATTR(jid, 0444, jid_show, NULL);
-GDLM_ATTR(first, 0444, lkfirst_show, NULL);
-GDLM_ATTR(first_done, 0444, first_done_show, NULL);
-GDLM_ATTR(recover, 0200, NULL, recover_store);
-GDLM_ATTR(recover_done, 0444, recover_done_show, NULL);
-GDLM_ATTR(recover_status, 0444, recover_status_show, NULL);
+GDLM_ATTR(proto_name, 0444, proto_name_show, NULL);
+GDLM_ATTR(block, 0644, block_show, block_store);
+GDLM_ATTR(withdraw, 0644, withdraw_show, withdraw_store);
+GDLM_ATTR(id, 0444, lkid_show, NULL);
+GDLM_ATTR(jid, 0444, jid_show, NULL);
+GDLM_ATTR(first, 0444, lkfirst_show, NULL);
+GDLM_ATTR(first_done, 0444, first_done_show, NULL);
+GDLM_ATTR(recover, 0600, NULL, recover_store);
+GDLM_ATTR(recover_done, 0444, recover_done_show, NULL);
+GDLM_ATTR(recover_status, 0444, recover_status_show, NULL);
static struct attribute *lock_module_attrs[] = {
&gdlm_attr_proto_name.attr,
--
1.6.2.5
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: torvalds@linux-foundation.org
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: GFS2: Pull request (fixes)
Date: Fri, 14 Aug 2009 14:01:34 +0100 [thread overview]
Message-ID: <1250254894.3298.204.camel@localhost.localdomain> (raw)
Hi,
Please consider pulling the following fix,
Steve.
------------------------------------------------------------------------
The following changes since commit 64f1607ffbbc772685733ea63e6f7f4183df1b16:
Linus Torvalds (1):
Linux 2.6.31-rc6
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-fixes.git master
Steven Whitehouse (1):
GFS2: Fix permissions on "recover" file
fs/gfs2/sys.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
---------------------------------------------------------------------------
>From d7e623da1a757fbd8c117fa29190ca8bef14dab3 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Tue, 11 Aug 2009 11:20:11 +0100
Subject: [PATCH] GFS2: Fix permissions on "recover" file
Although this file is only ever written and not read by
userspace, it seems that the utils are opening this
file O_RDWR, so we need to allow that.
Also fixes the whitespace which seemed to be broken.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Cc: David Teigland <teigland@redhat.com>
---
fs/gfs2/sys.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
index 23419dc..a7cbfbd 100644
--- a/fs/gfs2/sys.c
+++ b/fs/gfs2/sys.c
@@ -386,16 +386,16 @@ static ssize_t jid_show(struct gfs2_sbd *sdp, char *buf)
#define GDLM_ATTR(_name,_mode,_show,_store) \
static struct gfs2_attr gdlm_attr_##_name = __ATTR(_name,_mode,_show,_store)
-GDLM_ATTR(proto_name, 0444, proto_name_show, NULL);
-GDLM_ATTR(block, 0644, block_show, block_store);
-GDLM_ATTR(withdraw, 0644, withdraw_show, withdraw_store);
-GDLM_ATTR(id, 0444, lkid_show, NULL);
-GDLM_ATTR(jid, 0444, jid_show, NULL);
-GDLM_ATTR(first, 0444, lkfirst_show, NULL);
-GDLM_ATTR(first_done, 0444, first_done_show, NULL);
-GDLM_ATTR(recover, 0200, NULL, recover_store);
-GDLM_ATTR(recover_done, 0444, recover_done_show, NULL);
-GDLM_ATTR(recover_status, 0444, recover_status_show, NULL);
+GDLM_ATTR(proto_name, 0444, proto_name_show, NULL);
+GDLM_ATTR(block, 0644, block_show, block_store);
+GDLM_ATTR(withdraw, 0644, withdraw_show, withdraw_store);
+GDLM_ATTR(id, 0444, lkid_show, NULL);
+GDLM_ATTR(jid, 0444, jid_show, NULL);
+GDLM_ATTR(first, 0444, lkfirst_show, NULL);
+GDLM_ATTR(first_done, 0444, first_done_show, NULL);
+GDLM_ATTR(recover, 0600, NULL, recover_store);
+GDLM_ATTR(recover_done, 0444, recover_done_show, NULL);
+GDLM_ATTR(recover_status, 0444, recover_status_show, NULL);
static struct attribute *lock_module_attrs[] = {
&gdlm_attr_proto_name.attr,
--
1.6.2.5
next reply other threads:[~2009-08-14 13:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 13:01 Steven Whitehouse [this message]
2009-08-14 13:01 ` GFS2: Pull request (fixes) Steven Whitehouse
-- strict thread matches above, loose matches on Subject: below --
2014-09-16 10:11 [Cluster-devel] " Steven Whitehouse
2014-07-18 11:21 Steven Whitehouse
2014-01-02 12:41 Steven Whitehouse
2013-11-22 10:39 Steven Whitehouse
2013-08-19 9:26 Steven Whitehouse
2013-08-19 16:33 ` Linus Torvalds
2013-08-19 9:24 Steven Whitehouse
2013-06-04 15:40 Steven Whitehouse
2013-05-24 14:05 Steven Whitehouse
2013-04-05 10:34 Steven Whitehouse
2013-04-05 16:27 ` David Teigland
2013-04-05 16:51 ` Steven Whitehouse
2013-04-05 16:53 ` Linus Torvalds
2013-04-05 17:52 ` Steven Whitehouse
2013-01-28 10:31 Steven Whitehouse
2013-01-03 12:28 Steven Whitehouse
2012-11-07 10:58 Steven Whitehouse
2012-09-13 13:42 Steven Whitehouse
2012-04-11 10:21 Steven Whitehouse
2012-04-11 10:18 Steven Whitehouse
2012-02-28 11:49 Steven Whitehouse
2011-07-27 10:00 Steven Whitehouse
2011-07-14 15:16 Steven Whitehouse
2011-05-23 14:05 Steven Whitehouse
2011-04-19 9:13 Steven Whitehouse
2011-01-19 10:50 Steven Whitehouse
2010-11-29 13:42 Steven Whitehouse
2010-11-15 15:41 Steven Whitehouse
2010-09-17 13:59 Steven Whitehouse
2010-07-15 14:35 Steven Whitehouse
2010-05-25 8:51 Steven Whitehouse
2010-03-11 17:41 Steven Whitehouse
2010-02-12 11:37 Steven Whitehouse
2010-02-04 10:06 Steven Whitehouse
2010-02-02 10:07 [Cluster-devel] [GFS2] " Steven Whitehouse
2010-01-11 14:24 [Cluster-devel] GFS2: " Steven Whitehouse
2009-07-30 13:45 [Cluster-devel] GFS2: Pre-pull patch posting (fixes) Steven Whitehouse
2009-07-30 13:02 ` [Cluster-devel] GFS2: Pull request (fixes) Steven Whitehouse
2009-04-23 13:13 Steven Whitehouse
2009-01-07 10:21 Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250254894.3298.204.camel@localhost.localdomain \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.