All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Huang Ying <ying.huang@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [BUGFIX] crypto: Fix ctr(aes) testing by specifying geniv
Date: Fri, 14 Aug 2009 16:47:27 +0300	[thread overview]
Message-ID: <1250257647.25202.21.camel@localhost> (raw)
In-Reply-To: <20090814130241.GA7068@gondor.apana.org.au>

On Fri, 2009-08-14 at 23:02 +1000, Herbert Xu wrote:
> diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c
> index 03fb5fa..f6f0833 100644
> --- a/crypto/ablkcipher.c
> +++ b/crypto/ablkcipher.c
> @@ -183,6 +183,12 @@ EXPORT_SYMBOL_GPL(crypto_givcipher_type);
>  
>  const char *crypto_default_geniv(const struct crypto_alg *alg)
>  {
> +	if (((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) ==
> +	     CRYPTO_ALG_TYPE_BLKCIPHER ? alg->cra_blkcipher.ivsize :
> +					 alg->cra_ablkcipher.ivsize) !=
> +	    alg->cra_blocksize)
> +		return "chainiv";

I guess you used this cryptic construct instead of something more
readable because this is about a crypto algorithms? ;-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Huang Ying <ying.huang@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [BUGFIX] crypto: Fix ctr(aes) testing by specifying geniv
Date: Fri, 14 Aug 2009 16:47:27 +0300	[thread overview]
Message-ID: <1250257647.25202.21.camel@localhost> (raw)
In-Reply-To: <20090814130241.GA7068@gondor.apana.org.au>

On Fri, 2009-08-14 at 23:02 +1000, Herbert Xu wrote:
> diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c
> index 03fb5fa..f6f0833 100644
> --- a/crypto/ablkcipher.c
> +++ b/crypto/ablkcipher.c
> @@ -183,6 +183,12 @@ EXPORT_SYMBOL_GPL(crypto_givcipher_type);
>  
>  const char *crypto_default_geniv(const struct crypto_alg *alg)
>  {
> +	if (((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) ==
> +	     CRYPTO_ALG_TYPE_BLKCIPHER ? alg->cra_blkcipher.ivsize :
> +					 alg->cra_ablkcipher.ivsize) !=
> +	    alg->cra_blocksize)
> +		return "chainiv";

I guess you used this cryptic construct instead of something more
readable because this is about a crypto algorithms? ;-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


  reply	other threads:[~2009-08-14 13:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03  7:44 [BUGFIX] crypto: Fix ctr(aes) testing by specifying geniv Huang Ying
2009-08-05  9:45 ` Herbert Xu
2009-08-06  2:12   ` Huang Ying
2009-08-12  2:27     ` Huang Ying
2009-08-13  4:53       ` Herbert Xu
2009-08-13  7:39         ` Herbert Xu
2009-08-13 13:12           ` Herbert Xu
2009-08-14  1:01             ` Huang Ying
2009-08-14  1:05               ` Herbert Xu
2009-08-14 13:02             ` Herbert Xu
2009-08-14 13:47               ` Artem Bityutskiy [this message]
2009-08-14 13:47                 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250257647.25202.21.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.