From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: arun@linux.vnet.ibm.com
Cc: Gautham R Shenoy <ego@in.ibm.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Ingo Molnar <mingo@elte.hu>,
linuxppc-dev@lists.ozlabs.org,
Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [v2 PATCH 2/2]: pseries: Implement Pseries Processor Idle idle module.
Date: Wed, 26 Aug 2009 13:37:05 +0200 [thread overview]
Message-ID: <1251286625.1329.6.camel@twins> (raw)
In-Reply-To: <20090826113217.GA14758@linux.vnet.ibm.com>
On Wed, 2009-08-26 at 17:02 +0530, Arun R Bharadwaj wrote:
> * Peter Zijlstra <a.p.zijlstra@chello.nl> [2009-08-26 13:27:18]:
>
> > On Wed, 2009-08-26 at 16:40 +0530, Arun R Bharadwaj wrote:
> > > +void (*pm_idle)(void);
> > > +EXPORT_SYMBOL_GPL(pm_idle);
> >
> > Seriously.. this caused plenty problems over on x86 and you're doing the
> > exact same dumb thing?
> >
>
> Hi Peter,
>
> Cpuidle assumes pm_idle to be the default idle power management
> function. So i should either do this, or change the stuff in cpuidle.c
> so that it is more abstract.
I would much prefer the latter, I've been telling the x86 power folks to
fix this like forever, but they never seem to get around to it.
They even tried adding a second such unmanaged function pointer for
play-dead, instead of integrating everything into a single management
interface.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: arun@linux.vnet.ibm.com
Cc: Joel Schopp <jschopp@austin.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: Re: [v2 PATCH 2/2]: pseries: Implement Pseries Processor Idle idle module.
Date: Wed, 26 Aug 2009 13:37:05 +0200 [thread overview]
Message-ID: <1251286625.1329.6.camel@twins> (raw)
In-Reply-To: <20090826113217.GA14758@linux.vnet.ibm.com>
On Wed, 2009-08-26 at 17:02 +0530, Arun R Bharadwaj wrote:
> * Peter Zijlstra <a.p.zijlstra@chello.nl> [2009-08-26 13:27:18]:
>
> > On Wed, 2009-08-26 at 16:40 +0530, Arun R Bharadwaj wrote:
> > > +void (*pm_idle)(void);
> > > +EXPORT_SYMBOL_GPL(pm_idle);
> >
> > Seriously.. this caused plenty problems over on x86 and you're doing the
> > exact same dumb thing?
> >
>
> Hi Peter,
>
> Cpuidle assumes pm_idle to be the default idle power management
> function. So i should either do this, or change the stuff in cpuidle.c
> so that it is more abstract.
I would much prefer the latter, I've been telling the x86 power folks to
fix this like forever, but they never seem to get around to it.
They even tried adding a second such unmanaged function pointer for
play-dead, instead of integrating everything into a single management
interface.
next prev parent reply other threads:[~2009-08-26 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 11:07 [v2 PATCH 0/2]: cpuidle: Introducing cpuidle infrastructure to POWER Arun R Bharadwaj
2009-08-26 11:07 ` Arun R Bharadwaj
2009-08-26 11:08 ` [v2 PATCH 1/2]: pseries: Enable cpuidle for pSeries Arun R Bharadwaj
2009-08-26 11:08 ` Arun R Bharadwaj
2009-08-26 11:10 ` [v2 PATCH 2/2]: pseries: Implement Pseries Processor Idle idle module Arun R Bharadwaj
2009-08-26 11:10 ` Arun R Bharadwaj
2009-08-26 11:27 ` Peter Zijlstra
2009-08-26 11:27 ` Peter Zijlstra
2009-08-26 11:32 ` Arun R Bharadwaj
2009-08-26 11:32 ` Arun R Bharadwaj
2009-08-26 11:37 ` Peter Zijlstra [this message]
2009-08-26 11:37 ` Peter Zijlstra
2009-08-27 3:44 ` Benjamin Herrenschmidt
2009-08-27 3:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251286625.1329.6.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=arun@linux.vnet.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.