All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matt W. Benjamin" <matt@cohortfs.com>
To: Haomai Wang <haomaiwang@gmail.com>
Cc: Sage Weil <sage@newdream.net>, ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: widening Messenger::create
Date: Thu, 29 Jan 2015 12:13:27 -0500 (EST)	[thread overview]
Message-ID: <1251857046.66.1422551607854.JavaMail.root@thunderbeast.private.linuxbox.com> (raw)
In-Reply-To: <CACJqLyb1Vyf+Eb+fUtEYeBxRvFgiS1nN0gTdcQtTbF5ocgAXVQ@mail.gmail.com>

There is obvious overlap with policy, but policy is currently not well
structured for this use.

Changing or extending the policy interface seemed plausible, but also seemed
likely to run into more objections.

Matt

----- "Haomai Wang" <haomaiwang@gmail.com> wrote:

> I think it may better that Messenger impl can introspect itself by
> "type", "policy", config and related infos?
> 
> On Fri, Jan 30, 2015 at 12:44 AM, Matt W. Benjamin <matt@cohortfs.com>
> wrote:
> > Hi,
> >
> > ----- "Sage Weil" <sage@newdream.net> wrote:
> >
> >> On Thu, 29 Jan 2015, Matt W. Benjamin wrote:
> >> > Hi,
> >> >
> >> > I'm looking at ways to pass potentially messenger-specific
> options
> >> through the Messenger factory.
> >> > The immediate parameter I need to provide is the number of
> Accelio
> >> portals to set up (this should
> >> > vary by Messenger instance), but I expect others will be needed
> in
> >> future.  I don't think this fits
> >> > cleanly on to the Policy mechanism, though I looked at that.  I
> >> think I'd like to provide a
> >> > generalized argument to the Messenger factory, which can do the
> >> right thing for a given Messenger
> >> > (e.g., constructor).
> >>
> >> In the past we've mostly gotten away with impl-specific config
> >> options.
> >> Is that not sufficient here?  Because you need to pass different
> >> parameters to different instances maybe?
> >
> > Yes, exactly.
> >
> >>
> >> sage
> >
> >
> > --
> > Matt Benjamin
> > CohortFS, LLC.
> > 315 West Huron Street, Suite 140A
> > Ann Arbor, Michigan 48103
> >
> > http://cohortfs.com
> >
> > tel.  734-761-4689
> > fax.  734-769-8938
> > cel.  734-216-5309
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> ceph-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 
> -- 
> Best Regards,
> 
> Wheat
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Matt Benjamin
CohortFS, LLC.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://cohortfs.com

tel.  734-761-4689 
fax.  734-769-8938 
cel.  734-216-5309 

  reply	other threads:[~2015-01-29 17:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 16:34 widening Messenger::create Matt W. Benjamin
2015-01-29 16:42 ` Sage Weil
2015-01-29 16:44   ` Matt W. Benjamin
2015-01-29 17:05     ` Haomai Wang
2015-01-29 17:13       ` Matt W. Benjamin [this message]
2015-01-29 17:13     ` Sage Weil
     [not found] <1917094814.68.1422552099121.JavaMail.root@thunderbeast.private.linuxbox.com>
2015-01-29 17:23 ` Matt W. Benjamin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1251857046.66.1422551607854.JavaMail.root@thunderbeast.private.linuxbox.com \
    --to=matt@cohortfs.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=haomaiwang@gmail.com \
    --cc=sage@newdream.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.