From: "Matt W. Benjamin" <matt@cohortfs.com>
To: Sage Weil <sage@newdream.net>
Cc: ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: widening Messenger::create
Date: Thu, 29 Jan 2015 12:23:02 -0500 (EST) [thread overview]
Message-ID: <773946604.70.1422552182027.JavaMail.root@thunderbeast.private.linuxbox.com> (raw)
In-Reply-To: <1917094814.68.1422552099121.JavaMail.root@thunderbeast.private.linuxbox.com>
I was going to do a proplist arg type thing? I'll adapt it until hopefully shared happiness breaks out...
Matt
----- "Sage Weil" <sage@newdream.net> wrote:
> On Thu, 29 Jan 2015, Matt W. Benjamin wrote:
> > Hi,
> >
> > ----- "Sage Weil" <sage@newdream.net> wrote:
> >
> > > On Thu, 29 Jan 2015, Matt W. Benjamin wrote:
> > > > Hi,
> > > >
> > > > I'm looking at ways to pass potentially messenger-specific
> options
> > > > through the Messenger factory. The immediate parameter I need to
>
> > > > provide is the number of Accelio portals to set up (this should
> vary
> > > > by Messenger instance), but I expect others will be needed in
> > > > future. I don't think this fits cleanly on to the Policy
> mechanism,
> > > > though I looked at that. I think I'd like to provide a
> generalized
> > > > argument to the Messenger factory, which can do the right thing
> for
> > > > a given Messenger (e.g., constructor).
> > >
> > > In the past we've mostly gotten away with impl-specific config
> > > options.
> > > Is that not sufficient here? Because you need to pass different
> > > parameters to different instances maybe?
> >
> > Yes, exactly.
>
> Hmm, in that case I'd say if you can make it as generic as possible
> that's
> about all we can do that this point. Just a single arg now? We can
> easily expand the interface to a param struct later. (Or do that now
> if
> you prefer.. whatever works and looks reasonable!)
>
> sage
--
Matt Benjamin
CohortFS, LLC.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://cohortfs.com
tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309
next parent reply other threads:[~2015-01-29 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1917094814.68.1422552099121.JavaMail.root@thunderbeast.private.linuxbox.com>
2015-01-29 17:23 ` Matt W. Benjamin [this message]
2015-01-29 16:34 widening Messenger::create Matt W. Benjamin
2015-01-29 16:42 ` Sage Weil
2015-01-29 16:44 ` Matt W. Benjamin
2015-01-29 17:05 ` Haomai Wang
2015-01-29 17:13 ` Matt W. Benjamin
2015-01-29 17:13 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=773946604.70.1422552182027.JavaMail.root@thunderbeast.private.linuxbox.com \
--to=matt@cohortfs.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.