From: schen@mvista.com (Steve Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] arm: remove unused code in delay.S
Date: Tue, 22 Sep 2009 05:47:29 -0500 [thread overview]
Message-ID: <1253616449.3273.318.camel@linux-1lbu> (raw)
In-Reply-To: <1253369076.3273.299.camel@linux-1lbu>
Document #if 0 code block in delay.S and make it selectable for compile.
Comments by
Felipe Contreras <felipe.contreras@gmail.com>
Jamie Lokier <jamie@shareable.org>
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Krzysztof Halasa <khc@pm.waw.pl>
Marek Vasut <marek.vasut@gmail.com>
Pavel Machek <pavel@ucw.cz>
Sergei Shtylyov <sshtylyov@ru.mvista.com>
Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Signed-off-by: Steve Chen <schen@mvista.com>
---
arch/arm/Kconfig | 23 +++++++++++++++++++++++
arch/arm/lib/delay.S | 2 +-
2 files changed, 24 insertions(+), 1 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index aef63c8..9a5a49a 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -813,6 +813,29 @@ config ARM_ERRATA_460075
ACTLR register. Note that setting specific bits in the ACTLR
register
may not be available in non-secure mode.
+config OLD_CPU_DELAY
+ depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
+ bool "Different delay() code for some older CPUs"
+ help
+ Enable this if observing longer than expected delays. This code
+ improves delay accuracy for some CPUs. However, it can also cause
+ delay duration to be too short for others which leads to stability
+ issues.
+
+ In other words, do not enable unless you can guarantee that the
+ processor (or ALL of the processors if building a generic kernel)
+ delays for at least the time requested after enabling.
+
+ ARM610 and ARM710 are known to benefit from enabling this option.
+ It should not be enabled for StrongARMs, because it is known
+ to produce too short delays on those.
+
+ CPUs should enable this flag
+ ARM610 (rmk)
+ ARM710 (rmk)
+
+ CPUs should disable this flag
+ StrongARM (rmk)
endmenu
source "arch/arm/common/Kconfig"
diff --git a/arch/arm/lib/delay.S b/arch/arm/lib/delay.S
index 8d6a876..67e679b 100644
--- a/arch/arm/lib/delay.S
+++ b/arch/arm/lib/delay.S
@@ -42,7 +42,7 @@ ENTRY(__const_udelay) @ 0 <= r0 <= 0x7fffff06
@ Delay routine
ENTRY(__delay)
subs r0, r0, #1
-#if 0
+#ifdef CONFIG_OLD_CPU_DELAY
movls pc, lr
subs r0, r0, #1
movls pc, lr
prev parent reply other threads:[~2009-09-22 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 16:46 [PATCH v3] arm: remove unused code in delay.S Steve Chen
2009-09-18 18:39 ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-18 19:09 ` Uwe Kleine-König
2009-09-18 20:25 ` Steve Chen
2009-09-18 20:53 ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-18 21:51 ` Steve Chen
2009-09-19 12:55 ` [PATCH v4] " Steve Chen
2009-09-19 13:47 ` Uwe Kleine-König
2009-09-19 14:09 ` Steve Chen
2009-09-20 0:16 ` Felipe Contreras
2009-09-20 13:18 ` Steve Chen
2009-09-19 14:04 ` [PATCH v4.1] " Steve Chen
2009-09-22 10:47 ` Steve Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253616449.3273.318.camel@linux-1lbu \
--to=schen@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.