All of lore.kernel.org
 help / color / mirror / Atom feed
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm: remove unused code in delay.S
Date: Fri, 18 Sep 2009 22:53:49 +0200	[thread overview]
Message-ID: <20090918205349.GM29905@game.jcrosoft.org> (raw)
In-Reply-To: <1253305534.3273.283.camel@linux-1lbu>

On 15:25 Fri 18 Sep     , Steve Chen wrote:
> On Fri, 2009-09-18 at 21:09 +0200, Uwe Kleine-K?nig wrote:
> > Hello Steve,
> > 
> > On Fri, Sep 18, 2009 at 11:46:58AM -0500, Steve Chen wrote:
> > > Document #if 0 code block in delay.S and make it selectable for compile.
> > > 
> > > Signed-off-by: Steve Chen <schen@mvista.com>
> > > 
> > > ---
> > >  arch/arm/Kconfig     |   31 +++++++++++++++++++++++++++++++
> > >  arch/arm/lib/delay.S |    2 +-
> > >  2 files changed, 32 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > index aef63c8..f44cb70 100644
> > > --- a/arch/arm/Kconfig
> > > +++ b/arch/arm/Kconfig
> > > @@ -813,6 +813,37 @@ config ARM_ERRATA_460075
> > >  	  ACTLR register. Note that setting specific bits in the ACTLR
> > > register
> > >  	  may not be available in non-secure mode.
> > >  
> > > +config OLD_CPU_DELAY
> > > +	depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
> > > +	bool "Different delay() code for some older CPUs"
> > > +	def_bool n
> > as already noted, n is the default (that would better be expressed using
> > "default n" btw).
> 
> Jean-Christope/Uwe, I'll change it to "default n".
simply remove it will be better

Best Regards,
J.
> 
> > 
> > > +	help
> > > +	  Enable this if observing longer than expected delays.  This code
> > > +	  improves delay accuracy for some CPUs.  However, it can also cause
> > > +	  delay duration to be too short for others which leads to stability
> > > +	  issues.
> > > +
> > > +	  In other words, do not enable unless you can guarantee that the
> > > +	  processor (or ALL of the processors if building a generic kernel)
> > > +	  delays for at least the time requested after enabling.
> > > +
> > > +	  ARM610 and ARM710 are known to benefit from enabling this option.
> > > +	  It should not be enabled for StrongARMs, because it is known
> > > +	  to produce too short delays on those.
> > > +
> > > +	  Lastly, below are 2 lists.  The first list contains the processors
simply remove it will be better

Best Regards,
J.> > > +	  that would benefit from enabling this flag, and the second list
> > > +	  contains processor that are known to have issues.  Please note that
> > > +	  both lists are by no means complete.  Entries are expected to be
> > > +	  added and refined.  If you like to update the list, please send a
> > > +	  patch to Linux ARM mailing list.
> > I'd delete the last three sentences.
> 
> Well, do.  Anything after "Entries are expected to be..." will be
> deleted.
> 
> > 
> > > +	  CPUs should enable this flag
> > > +		ARM610
> > > +		ARM710
> > > +
> > > +	  CPUs should disable this flag
> > > +		StrongARM
> > everything armv5+ ?
IIRC StrongARM is armv4
ARM610 & 710 is armv3

Best Regards,
J.

  reply	other threads:[~2009-09-18 20:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 16:46 [PATCH v3] arm: remove unused code in delay.S Steve Chen
2009-09-18 18:39 ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-18 19:09 ` Uwe Kleine-König
2009-09-18 20:25   ` Steve Chen
2009-09-18 20:53     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-09-18 21:51       ` Steve Chen
2009-09-19 12:55       ` [PATCH v4] " Steve Chen
2009-09-19 13:47         ` Uwe Kleine-König
2009-09-19 14:09           ` Steve Chen
2009-09-20  0:16             ` Felipe Contreras
2009-09-20 13:18               ` Steve Chen
2009-09-19 14:04         ` [PATCH v4.1] " Steve Chen
2009-09-22 10:47           ` [PATCH v5] " Steve Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090918205349.GM29905@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.