From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roger Quadros <ext-roger.quadros@nokia.com>
Cc: sameo@linux.intel.com, tony@atomide.com,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled
Date: Thu, 01 Oct 2009 11:36:29 +0300 [thread overview]
Message-ID: <1254386189.32310.20.camel@localhost> (raw)
In-Reply-To: <1254385536-26912-1-git-send-email-ext-roger.quadros@nokia.com>
On Thu, 2009-10-01 at 11:25 +0300, Roger Quadros wrote:
> if (twl_has_bci() && pdata->bci && !(features & TPS_SUBSET)) {
> child = add_child(3, "twl4030_bci",
> @@ -532,16 +531,61 @@ add_children(struct twl4030_platform_data *pdata, unsigned long features)
> }
>
> if (twl_has_usb() && pdata->usb) {
> +
Why is this extra line?
> + static struct regulator_consumer_supply usb1v5 = {
> + .supply = "usb1v5",
> + };
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roger Quadros <ext-roger.quadros@nokia.com>
Cc: sameo@linux.intel.com, tony@atomide.com,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled
Date: Thu, 01 Oct 2009 11:36:29 +0300 [thread overview]
Message-ID: <1254386189.32310.20.camel@localhost> (raw)
In-Reply-To: <1254385536-26912-1-git-send-email-ext-roger.quadros@nokia.com>
On Thu, 2009-10-01 at 11:25 +0300, Roger Quadros wrote:
> if (twl_has_bci() && pdata->bci && !(features & TPS_SUBSET)) {
> child = add_child(3, "twl4030_bci",
> @@ -532,16 +531,61 @@ add_children(struct twl4030_platform_data *pdata, unsigned long features)
> }
>
> if (twl_has_usb() && pdata->usb) {
> +
Why is this extra line?
> + static struct regulator_consumer_supply usb1v5 = {
> + .supply = "usb1v5",
> + };
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-10-01 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 8:25 [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled Roger Quadros
2009-10-01 8:36 ` Artem Bityutskiy [this message]
2009-10-01 8:36 ` Artem Bityutskiy
2009-10-01 8:41 ` Roger Quadros
2009-10-09 12:32 ` Roger Quadros
2009-10-09 15:55 ` Roger Quadros
2009-10-09 16:14 ` Samuel Ortiz
2009-10-09 16:14 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254386189.32310.20.camel@localhost \
--to=dedekind1@gmail.com \
--cc=ext-roger.quadros@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.