From: Liam Girdwood <lrg@slimlogic.co.uk>
To: pl bossart <bossart.nospam@gmail.com>
Cc: Stefan Schmidt <stefan@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Ian Molton <ian@mnementh.co.uk>,
Graeme Gregory <gg@slimlogic.co.uk>,
Stefan Schmidt <stefan@datenfreihafen.org>
Subject: Re: [PATCH] ascenario: Add scenario support to alsa-lib
Date: Thu, 01 Oct 2009 14:54:00 +0100 [thread overview]
Message-ID: <1254405240.5847.227.camel@odin> (raw)
In-Reply-To: <6160a5130910010639u11b764bfh92cfb6f6aef671c@mail.gmail.com>
On Thu, 2009-10-01 at 08:39 -0500, pl bossart wrote:
> +/** QOS
> + *
> + * Defines Audio Quality of Service
> + */
> +#define SND_QOS_HIFI 0
> +#define SND_QOS_VOICE 1
> +#define SND_QOS_SYSTEM 2
>
> My $0.02 comment is that I don't know what QOS entails. I have no
> issue with all the other defines, but this one isn't quite clear.
> What exactly is supposed to happen if I set the QOS to voice? A lower
> SNR for voice? A lower latency for voice with a lower group delay? A
> lower oversampling ratio? An optimized routing for voice? All of the
> above?
>
It's only about power usage here. i.e. run CODEC with slower clocks internally, may lower SNR.
So maybe
define SND_POWER_QOS_HIFI 0
>
> +#define SND_SCN_PHONECALL_HANDSET "phonecall handset"
> +#define SND_SCN_PHONECALL_HEADSET "phonecall headset"
> +#define SND_SCN_PHONECALL_BLUETOOTH "phonecall bluetooth"
> +#define SND_SCN_PHONECALL_IP "phonecall ip"
>
> Same here, this is ambiguous, you can have an IP call over bluetooth.
> Which scenario would you use then?
> I guess if you want the scenarios to be used by apps in a portable
> way, a clearer definition of each scenario is probably needed?
These are ambiguous, I guess we need to have
#define SND_SCN_PHONECALL_GSM_HANDSET "phonecall gsm handset"
#define SND_SCN_PHONECALL_BT_HANDSET "phonecall bt handset"
#define SND_SCN_PHONECALL_IP_HANDSET "phonecall ip handset"
For gsm, bluetooth and VOIP handset phone calls respectively.
Thanks
Liam
next prev parent reply other threads:[~2009-10-01 13:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 9:47 [RFC] Add scenario management Stefan Schmidt
2009-10-01 9:47 ` [PATCH] ascenario: Add scenario support to alsa-lib Stefan Schmidt
2009-10-01 12:28 ` Mark Brown
2009-10-01 12:48 ` Liam Girdwood
2009-10-01 13:02 ` Mark Brown
2009-10-01 14:06 ` Liam Girdwood
2009-10-01 14:18 ` Mark Brown
2009-10-01 13:19 ` Stefan Schmidt
2009-10-01 13:24 ` Mark Brown
2009-10-01 13:38 ` Stefan Schmidt
2009-10-01 13:39 ` pl bossart
2009-10-01 13:54 ` Liam Girdwood [this message]
2009-10-01 14:11 ` Stefan Schmidt
2009-10-01 15:08 ` Stefan Schmidt
2009-10-05 8:27 ` Stefan Schmidt
2009-10-05 9:14 ` Jaroslav Kysela
2009-10-05 9:35 ` Stefan Schmidt
2009-10-06 8:23 ` Jaroslav Kysela
2009-10-06 8:41 ` Takashi Iwai
2009-10-06 9:00 ` Jaroslav Kysela
2009-10-06 9:13 ` Takashi Iwai
2009-10-07 8:10 ` Jaroslav Kysela
2009-10-07 8:52 ` Takashi Iwai
2009-10-07 9:47 ` Jaroslav Kysela
2009-10-07 9:55 ` Takashi Iwai
2009-10-06 9:28 ` Takashi Iwai
2009-10-06 11:05 ` Jaroslav Kysela
2009-10-06 13:33 ` Jaroslav Kysela
2009-10-06 13:46 ` Takashi Iwai
2009-10-07 13:48 ` Stefan Schmidt
2009-10-06 15:12 ` Stefan Schmidt
2009-10-06 15:54 ` [PATCH 0/3] ascenario: Bring it to compile after API changes Stefan Schmidt
2009-10-06 15:54 ` [PATCH 1/3] ascenario: Fix typedef for snd_scenario_t Stefan Schmidt
2009-10-06 16:04 ` Takashi Iwai
2009-10-06 17:08 ` Stefan Schmidt
2009-10-06 17:16 ` Jaroslav Kysela
2009-10-06 17:42 ` Stefan Schmidt
2009-10-06 15:54 ` [PATCH 2/3] ascenario: Fix usage of new typedefed snd_scenario_t Stefan Schmidt
2009-10-06 15:54 ` [PATCH 3/3] ascenario: Catchup with function declaration changes Stefan Schmidt
2009-10-07 13:53 ` [PATCH] ascenario: Add scenario support to alsa-lib Mark Brown
2009-10-06 10:29 ` Stefan Schmidt
2009-10-01 9:47 ` [PATCH] ascenario: Add dump and configure utils for ascneario Stefan Schmidt
2009-10-02 9:12 ` [RFC] Add scenario management Takashi Iwai
2009-10-02 9:55 ` Stefan Schmidt
2009-10-02 9:58 ` Takashi Iwai
2009-10-02 9:58 ` Jaroslav Kysela
2009-10-02 10:12 ` Takashi Iwai
2009-10-02 10:45 ` Liam Girdwood
2009-10-02 11:03 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254405240.5847.227.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=bossart.nospam@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=ian@mnementh.co.uk \
--cc=stefan@datenfreihafen.org \
--cc=stefan@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.