From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: Ian Molton <ian@mnementh.co.uk>,
alsa-devel@alsa-project.org, Graeme Gregory <gg@slimlogic.co.uk>,
Stefan Schmidt <stefan@slimlogic.co.uk>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ascenario: Add scenario support to alsa-lib
Date: Thu, 1 Oct 2009 14:24:18 +0100 [thread overview]
Message-ID: <20091001132417.GA26663@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20091001131948.GA5936@excalibur.local>
On Thu, Oct 01, 2009 at 03:19:48PM +0200, Stefan Schmidt wrote:
> On Thu, 2009-10-01 at 13:28, Mark Brown wrote:
> > > +/** Scenario ID's
> > > + *
> > > + * Standard Scenario ID's - Add new scenarios at the end.
> > > + */
> > Extra 's here.
> That way?
> /**
> * Scenario ID's
> *
> * Standard Scenario ID's - Add new scenarios at the end.
> */
There shouldn't be any 's in the above at all ("Scenarios IDs" instead),
those are just plain plurals - just a trivial grammar nit.
> > I guess the idea is that in the future this will be removed and the
> > scenario API will use inotify or similar to pick up changes.
> Indeed. Certainly a Todo item for later enhancements. Do you guys prefer such
> todo items in the code or noted somewhere else?
I have no great preference either way.
next prev parent reply other threads:[~2009-10-01 13:24 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 9:47 [RFC] Add scenario management Stefan Schmidt
2009-10-01 9:47 ` [PATCH] ascenario: Add scenario support to alsa-lib Stefan Schmidt
2009-10-01 12:28 ` Mark Brown
2009-10-01 12:48 ` Liam Girdwood
2009-10-01 13:02 ` Mark Brown
2009-10-01 14:06 ` Liam Girdwood
2009-10-01 14:18 ` Mark Brown
2009-10-01 13:19 ` Stefan Schmidt
2009-10-01 13:24 ` Mark Brown [this message]
2009-10-01 13:38 ` Stefan Schmidt
2009-10-01 13:39 ` pl bossart
2009-10-01 13:54 ` Liam Girdwood
2009-10-01 14:11 ` Stefan Schmidt
2009-10-01 15:08 ` Stefan Schmidt
2009-10-05 8:27 ` Stefan Schmidt
2009-10-05 9:14 ` Jaroslav Kysela
2009-10-05 9:35 ` Stefan Schmidt
2009-10-06 8:23 ` Jaroslav Kysela
2009-10-06 8:41 ` Takashi Iwai
2009-10-06 9:00 ` Jaroslav Kysela
2009-10-06 9:13 ` Takashi Iwai
2009-10-07 8:10 ` Jaroslav Kysela
2009-10-07 8:52 ` Takashi Iwai
2009-10-07 9:47 ` Jaroslav Kysela
2009-10-07 9:55 ` Takashi Iwai
2009-10-06 9:28 ` Takashi Iwai
2009-10-06 11:05 ` Jaroslav Kysela
2009-10-06 13:33 ` Jaroslav Kysela
2009-10-06 13:46 ` Takashi Iwai
2009-10-07 13:48 ` Stefan Schmidt
2009-10-06 15:12 ` Stefan Schmidt
2009-10-06 15:54 ` [PATCH 0/3] ascenario: Bring it to compile after API changes Stefan Schmidt
2009-10-06 15:54 ` [PATCH 1/3] ascenario: Fix typedef for snd_scenario_t Stefan Schmidt
2009-10-06 16:04 ` Takashi Iwai
2009-10-06 17:08 ` Stefan Schmidt
2009-10-06 17:16 ` Jaroslav Kysela
2009-10-06 17:42 ` Stefan Schmidt
2009-10-06 15:54 ` [PATCH 2/3] ascenario: Fix usage of new typedefed snd_scenario_t Stefan Schmidt
2009-10-06 15:54 ` [PATCH 3/3] ascenario: Catchup with function declaration changes Stefan Schmidt
2009-10-07 13:53 ` [PATCH] ascenario: Add scenario support to alsa-lib Mark Brown
2009-10-06 10:29 ` Stefan Schmidt
2009-10-01 9:47 ` [PATCH] ascenario: Add dump and configure utils for ascneario Stefan Schmidt
2009-10-02 9:12 ` [RFC] Add scenario management Takashi Iwai
2009-10-02 9:55 ` Stefan Schmidt
2009-10-02 9:58 ` Takashi Iwai
2009-10-02 9:58 ` Jaroslav Kysela
2009-10-02 10:12 ` Takashi Iwai
2009-10-02 10:45 ` Liam Girdwood
2009-10-02 11:03 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001132417.GA26663@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=gg@slimlogic.co.uk \
--cc=ian@mnementh.co.uk \
--cc=lrg@slimlogic.co.uk \
--cc=stefan@datenfreihafen.org \
--cc=stefan@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.