* Re: [Bug 14276] nfsroot will not remount rw and claims illegal options [not found] ` <200910041748.n94HmwPY005082-jEpIWWs/U2wOASNP4CLbKB2eb7JE58TQ@public.gmane.org> @ 2009-10-04 19:06 ` Trond Myklebust [not found] ` <1254683162.9064.2.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Trond Myklebust @ 2009-10-04 19:06 UTC (permalink / raw) To: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r Cc: linux-nfs, Mr. Charles Edward Lever, Hans de Bruin On Sun, 2009-10-04 at 17:48 +0000, bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=14276 > > > > > > --- Comment #6 from Hans de Bruin <bruinjm-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2009-10-04 17:48:57 --- > hans@orion:/var/diskless/kernel/linux-2.6$ git bisect bad > 53a0b9c4c99ab0085a06421f71592722e5b3fd5f is first bad commit > commit 53a0b9c4c99ab0085a06421f71592722e5b3fd5f > Author: Chuck Lever <chuck.lever@oracle.com> > Date: Sun Aug 9 15:09:36 2009 -0400 > > NFS: Replace nfs_parse_ip_address() with rpc_pton() > > Clean up: Use the common routine now provided in sunrpc.ko for parsing > mount > addresses. > > Signed-off-by: Chuck Lever <chuck.lever@oracle.com> > Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> > > :040000 040000 31c3998309b2c325b7ea927498e1a7e78e0e7747 > 513edbc936111eda9d1646db17e7240c77a32c42 M fs > hans@orion:/var/diskless/kernel/linux-2.6$ OK. Switching over to email. Chuck, can you see how the rpc_pton() might be breaking nfsroot? The cmdline is of the form root=/dev/nfs nfsroot=10.10.0.2:/nfs/gemini,v3,tcp ro ip=::::::dhcp Cheers Trond ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1254683162.9064.2.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>]
* Re: [Bug 14276] nfsroot will not remount rw and claims illegal options [not found] ` <1254683162.9064.2.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org> @ 2009-10-04 21:59 ` Trond Myklebust [not found] ` <1254693598.30515.59.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Trond Myklebust @ 2009-10-04 21:59 UTC (permalink / raw) To: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r Cc: linux-nfs, Mr. Charles Edward Lever, Hans de Bruin On Sun, 2009-10-04 at 15:06 -0400, Trond Myklebust wrote: > Chuck, can you see how the rpc_pton() might be breaking nfsroot? > The cmdline is of the form > > root=/dev/nfs nfsroot=10.10.0.2:/nfs/gemini,v3,tcp ro ip=::::::dhcp I think I see it... The difference is that rpc_pton4() starts with memset(sap, 0, sizeof(struct sockaddr_in)); That clears the port number that was set in nfs_remount(), and so the comparison in nfs_compare_remount_data() fails. Does the following patch fix the problem? -------------------------------------------------------------------------- NFS: Fix port initialisation in nfs_remount() From: Trond Myklebust <Trond.Myklebust@netapp.com> The recent changeset 53a0b9c4c99ab0085a06421f71592722e5b3fd5f (NFS: Replace nfs_parse_ip_address() with rpc_pton()) broke nfs_remount, since the call to rpc_pton() will zero out the port number in data->nfs_server.address. This is actually due to a bug in nfs_remount: it should be looking at the port number in nfs_server.port instead... Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> --- fs/nfs/super.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 0d14704..fb3b280 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -1846,9 +1846,10 @@ nfs_compare_remount_data(struct nfs_server *nfss, data->acdirmin != nfss->acdirmin / HZ || data->acdirmax != nfss->acdirmax / HZ || data->timeo != (10U * nfss->client->cl_timeout->to_initval / HZ) || + data->nfs_server.port != nfss->port || data->nfs_server.addrlen != nfss->nfs_client->cl_addrlen || - memcmp(&data->nfs_server.address, &nfss->nfs_client->cl_addr, - data->nfs_server.addrlen) != 0) + !rpc_cmp_addr(&data->nfs_server.address, + &nfss->nfs_client->cl_addr)) return -EINVAL; return 0; @@ -1891,6 +1892,7 @@ nfs_remount(struct super_block *sb, int *flags, char *raw_data) data->acdirmin = nfss->acdirmin / HZ; data->acdirmax = nfss->acdirmax / HZ; data->timeo = 10U * nfss->client->cl_timeout->to_initval / HZ; + data->nfs_server.port = nfss->port; data->nfs_server.addrlen = nfss->nfs_client->cl_addrlen; memcpy(&data->nfs_server.address, &nfss->nfs_client->cl_addr, data->nfs_server.addrlen); ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1254693598.30515.59.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>]
* Re: [Bug 14276] nfsroot will not remount rw and claims illegal options [not found] ` <1254693598.30515.59.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org> @ 2009-10-05 15:00 ` Chuck Lever 0 siblings, 0 replies; 4+ messages in thread From: Chuck Lever @ 2009-10-05 15:00 UTC (permalink / raw) To: Trond Myklebust Cc: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r, linux-nfs, Hans de Bruin On Oct 4, 2009, at 5:59 PM, Trond Myklebust wrote: > On Sun, 2009-10-04 at 15:06 -0400, Trond Myklebust wrote: >> Chuck, can you see how the rpc_pton() might be breaking nfsroot? >> The cmdline is of the form >> >> root=/dev/nfs nfsroot=10.10.0.2:/nfs/gemini,v3,tcp ro >> ip=::::::dhcp > > I think I see it... > > The difference is that rpc_pton4() starts with > > memset(sap, 0, sizeof(struct sockaddr_in)); > > That clears the port number that was set in nfs_remount(), and so the > comparison in nfs_compare_remount_data() fails. > > Does the following patch fix the problem? > > -------------------------------------------------------------------------- > NFS: Fix port initialisation in nfs_remount() > From: Trond Myklebust <Trond.Myklebust@netapp.com> > > The recent changeset 53a0b9c4c99ab0085a06421f71592722e5b3fd5f (NFS: > Replace > nfs_parse_ip_address() with rpc_pton()) broke nfs_remount, since the > call > to rpc_pton() will zero out the port number in data- > >nfs_server.address. > > This is actually due to a bug in nfs_remount: it should be looking > at the > port number in nfs_server.port instead... The analysis sounds correct. After the options are parsed, nfs_server.port is the port number the user specified on the command line. The user-specified value is saved separately because later the socket address's port number can be changed via an rpcbind. In the case of a remount, if the port value isn't changed by the new options, the client needs to know what the originally specified value was. > Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Acked-by: Chuck Lever <chuck.lever@oracle.com> I don't know if this will address the presenting problem, but yes, nfs_remount() is definitely not correct. > --- > > fs/nfs/super.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index 0d14704..fb3b280 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -1846,9 +1846,10 @@ nfs_compare_remount_data(struct nfs_server > *nfss, > data->acdirmin != nfss->acdirmin / HZ || > data->acdirmax != nfss->acdirmax / HZ || > data->timeo != (10U * nfss->client->cl_timeout->to_initval / > HZ) || > + data->nfs_server.port != nfss->port || > data->nfs_server.addrlen != nfss->nfs_client->cl_addrlen || > - memcmp(&data->nfs_server.address, &nfss->nfs_client->cl_addr, > - data->nfs_server.addrlen) != 0) > + !rpc_cmp_addr(&data->nfs_server.address, > + &nfss->nfs_client->cl_addr)) > return -EINVAL; > > return 0; > @@ -1891,6 +1892,7 @@ nfs_remount(struct super_block *sb, int > *flags, char *raw_data) > data->acdirmin = nfss->acdirmin / HZ; > data->acdirmax = nfss->acdirmax / HZ; > data->timeo = 10U * nfss->client->cl_timeout->to_initval / HZ; > + data->nfs_server.port = nfss->port; > data->nfs_server.addrlen = nfss->nfs_client->cl_addrlen; > memcpy(&data->nfs_server.address, &nfss->nfs_client->cl_addr, > data->nfs_server.addrlen); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever chuck[dot]lever[at]oracle[dot]com ^ permalink raw reply [flat|nested] 4+ messages in thread
* 2.6.32-rc1-git2: Reported regressions from 2.6.31 @ 2009-10-01 19:26 Rafael J. Wysocki 2009-10-01 19:38 ` [Bug #14276] nfsroot will not remount rw and claims illegal options Rafael J. Wysocki 0 siblings, 1 reply; 4+ messages in thread From: Rafael J. Wysocki @ 2009-10-01 19:26 UTC (permalink / raw) To: Linux Kernel Mailing List Cc: Adrian Bunk, Andrew Morton, Linus Torvalds, Natalie Protasevich, Kernel Testers List, Network Development, Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List, DRI [Notes: * Here's the first summary report of known regressions from 2.6.31. There's not too many of them at the moment, which is nice. * We're still getting quite a number of reports of regressions from 2.6.30 and it's been that way since 2.6.31 was released. For details please see the summary report of regressions 2.6.30 -> 2.6.31 that will follow shortly.] This message contains a list of some regressions from 2.6.31, for which there are no fixes in the mainline I know of. If any of them have been fixed already, please let me know. If you know of any other unresolved regressions from 2.6.31, please let me know either and I'll add them to the list. Also, please let me know if any of the entries below are invalid. Each entry from the list will be sent additionally in an automatic reply to this message with CCs to the people involved in reporting and handling the issue. Listed regressions statistics: Date Total Pending Unresolved ---------------------------------------- 2009-10-02 22 15 9 Unresolved regressions ---------------------- Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14299 Subject : oops in wireless, iwl3945 related? Submitter : Pavel Machek <pavel@ucw.cz> Date : 2009-09-29 17:12 (3 days old) References : http://marc.info/?l=linux-kernel&m=125424439725743&w=4 Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14298 Subject : warning at manage.c:361 (set_irq_wake), matrix-keypad related? Submitter : Pavel Machek <pavel@ucw.cz> Date : 2009-09-30 20:07 (2 days old) References : http://marc.info/?l=linux-kernel&m=125434130703538&w=4 Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14297 Subject : console resume broken since ba15ab0e8d Submitter : Sascha Hauer <s.hauer@pengutronix.de> Date : 2009-09-30 15:11 (2 days old) References : http://marc.info/?l=linux-kernel&m=125432349404060&w=4 Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14296 Subject : spitz boots but suspend/resume is broken Submitter : Pavel Machek <pavel@ucw.cz> Date : 2009-09-30 12:06 (2 days old) References : http://marc.info/?l=linux-kernel&m=125431244516449&w=4 Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14279 Subject : Suspend to RAM freeze totally since 2.6.32-rc1 Submitter : Christian Casteyde <casteyde.christian@free.fr> Date : 2009-09-30 18:14 (2 days old) Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14277 Subject : Caught 8-bit read from freed memory in b43 driver at association Submitter : Christian Casteyde <casteyde.christian@free.fr> Date : 2009-09-30 18:06 (2 days old) Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14276 Subject : nfsroot will not remount rw and claims illegal options Submitter : Hans de Bruin <bruinjm@xs4all.nl> Date : 2009-09-30 15:08 (2 days old) Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14260 Subject : T400 suspend/resume regression Submitter : Theodore Tso <tytso@mit.edu> Date : 2009-09-26 6:57 (6 days old) References : http://marc.info/?l=linux-kernel&m=125394827806011&w=4 Handled-By : Rafael J. Wysocki <rjw@sisk.pl> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14214 Subject : BUG at drivers/scsi/scsi_lib.c:1108! Submitter : Plamen Petrov <pvp-lsts@fs.ru.acad.bg> Date : 2009-09-23 11:13 (9 days old) Regressions with patches ------------------------ Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14302 Subject : Kernel panic on i386 machine when booting with profile=2 Submitter : Shi, Alex <alex.shi@intel.com> Date : 2009-10-01 3:23 (1 days old) References : http://marc.info/?l=linux-kernel&m=125436749607199&w=4 Handled-By : Alex Shi <alex.shi@intel.com> Patch : http://patchwork.kernel.org/patch/50813/ Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14300 Subject : BUG_ON crash w/ ext4 Submitter : Markus Trippelsdorf <markus@trippelsdorf.de> Date : 2009-10-01 1:41 (1 days old) References : http://marc.info/?l=linux-kernel&m=125436130800340&w=4 http://marc.info/?l=linux-kernel&m=125436568504914&w=4 Handled-By : Theodore Tso <tytso@mit.edu> Patch : http://patchwork.kernel.org/patch/50810/ Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14278 Subject : New message "NOHZ: local_softirq_pending 08" at each ping request Submitter : Christian Casteyde <casteyde.christian@free.fr> Date : 2009-09-30 18:12 (2 days old) Handled-By : Michael Buesch <mb@bu3sch.de> Patch : http://bugzilla.kernel.org/attachment.cgi?id=23220 Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14271 Subject : ACPI boot memory leaks Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com> Date : 2009-09-29 9:18 (3 days old) References : http://marc.info/?l=linux-kernel&m=125421594111690&w=4 Handled-By : Bjorn Helgaas <bjorn.helgaas@hp.com> Patch : http://patchwork.kernel.org/patch/50565/ Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14259 Subject : NFS problem with past 2.6.31 git tree Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com> Date : 2009-09-25 15:12 (7 days old) References : http://marc.info/?l=linux-kernel&m=125389156504570&w=4 Handled-By : Trond Myklebust <Trond.Myklebust@netapp.com> Patch : http://patchwork.kernel.org/patch/50428/ Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14247 Subject : ACPI Exception: AE_TIME, Returned by Handler for [EmbeddedControl] flooding logs Submitter : Thomas Backlund <tmb@mandriva.org> Date : 2009-09-25 15:08 (7 days old) References : http://lkml.org/lkml/2009/9/25/121 Handled-By : Alexey Starikovskiy <astarikovskiy@suse.de> Patch : http://patchwork.kernel.org/patch/50516/ For details, please visit the bug entries and follow the links given in references. As you can see, there is a Bugzilla entry for each of the listed regressions. There also is a Bugzilla entry used for tracking the regressions from 2.6.31, unresolved as well as resolved, at: http://bugzilla.kernel.org/show_bug.cgi?id=14230 Please let me know if there are any Bugzilla entries that should be added to the list in there. Thanks, Rafael ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug #14276] nfsroot will not remount rw and claims illegal options 2009-10-01 19:26 2.6.32-rc1-git2: Reported regressions from 2.6.31 Rafael J. Wysocki @ 2009-10-01 19:38 ` Rafael J. Wysocki 0 siblings, 0 replies; 4+ messages in thread From: Rafael J. Wysocki @ 2009-10-01 19:38 UTC (permalink / raw) To: Linux Kernel Mailing List Cc: Kernel Testers List, Hans de Bruin, Trond Myklebust This message has been generated automatically as a part of a report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.31. Please verify if it still should be listed and let me know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14276 Subject : nfsroot will not remount rw and claims illegal options Submitter : Hans de Bruin <bruinjm@xs4all.nl> Date : 2009-09-30 15:08 (2 days old) ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-10-05 15:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-14276-104@http.bugzilla.kernel.org/>
[not found] ` <200910041748.n94HmwPY005082@demeter.kernel.org>
[not found] ` <200910041748.n94HmwPY005082-jEpIWWs/U2wOASNP4CLbKB2eb7JE58TQ@public.gmane.org>
2009-10-04 19:06 ` [Bug 14276] nfsroot will not remount rw and claims illegal options Trond Myklebust
[not found] ` <1254683162.9064.2.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-10-04 21:59 ` Trond Myklebust
[not found] ` <1254693598.30515.59.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-10-05 15:00 ` Chuck Lever
2009-10-01 19:26 2.6.32-rc1-git2: Reported regressions from 2.6.31 Rafael J. Wysocki
2009-10-01 19:38 ` [Bug #14276] nfsroot will not remount rw and claims illegal options Rafael J. Wysocki
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.