From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: balbir@linux.vnet.ibm.com
Cc: linux-arch@vger.kernel.org, Gautham R Shenoy <ego@in.ibm.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
arun@linux.vnet.ibm.com, Ingo Molnar <mingo@elte.hu>,
linuxppc-dev@lists.ozlabs.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [v7 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.
Date: Wed, 07 Oct 2009 15:24:17 +0200 [thread overview]
Message-ID: <1254921857.26976.249.camel@twins> (raw)
In-Reply-To: <20091007114719.GH6818@balbir.in.ibm.com>
On Wed, 2009-10-07 at 17:17 +0530, Balbir Singh wrote:
> > The objective of the refactoring is to have a single common idle
> > routine management framework (remove pm_idle) and we have it done
> > through cpuidle registration framework. We can incrementally remove
> > the per-cpu registration later easily by splitting the cpuidle_driver
> > structure.
> >
>
> Yes, incremental refactoring makes the most sense from the do not
> break as you refactor point of view.
Sure,.. but I would have though getting rid of the per-cpu-ish-ness
would have made the latter patches in this series easier. But maybe I'm
lazy ;-)
Let me go over the patches one more time, but they do look ok.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: balbir@linux.vnet.ibm.com
Cc: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Arjan van de Ven <arjan@infradead.org>,
arun@linux.vnet.ibm.com, Joel Schopp <jschopp@austin.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Dipankar Sarma <dipankar@in.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arch@vger.kernel.org
Subject: Re: [v7 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.
Date: Wed, 07 Oct 2009 15:24:17 +0200 [thread overview]
Message-ID: <1254921857.26976.249.camel@twins> (raw)
Message-ID: <20091007132417.Gc1kh1F36FvfF3-gipnoBYxCa1WoNTDncGbkzcVm5zk@z> (raw)
In-Reply-To: <20091007114719.GH6818@balbir.in.ibm.com>
On Wed, 2009-10-07 at 17:17 +0530, Balbir Singh wrote:
> > The objective of the refactoring is to have a single common idle
> > routine management framework (remove pm_idle) and we have it done
> > through cpuidle registration framework. We can incrementally remove
> > the per-cpu registration later easily by splitting the cpuidle_driver
> > structure.
> >
>
> Yes, incremental refactoring makes the most sense from the do not
> break as you refactor point of view.
Sure,.. but I would have though getting rid of the per-cpu-ish-ness
would have made the latter patches in this series easier. But maybe I'm
lazy ;-)
Let me go over the patches one more time, but they do look ok.
next prev parent reply other threads:[~2009-10-07 13:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 15:24 [v7 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER Arun R Bharadwaj
2009-10-06 15:24 ` Arun R Bharadwaj
2009-10-06 15:24 ` Arun R Bharadwaj
2009-10-06 15:26 ` [v7 PATCH 1/7]: cpuidle: cleanup drivers/cpuidle/cpuidle.c Arun R Bharadwaj
2009-10-06 15:26 ` Arun R Bharadwaj
2009-10-06 15:26 ` Arun R Bharadwaj
2009-10-06 15:30 ` [v7 PATCH 2/7]: cpuidle: implement a list based approach to register a set of idle routines Arun R Bharadwaj
2009-10-06 15:30 ` Arun R Bharadwaj
2009-10-06 15:30 ` Arun R Bharadwaj
2009-10-06 15:31 ` [v7 PATCH 3/7]: x86: refactor x86 idle power management code and remove all instances of pm_idle Arun R Bharadwaj
2009-10-06 15:31 ` Arun R Bharadwaj
2009-10-06 15:31 ` Arun R Bharadwaj
2009-10-07 14:45 ` Peter Zijlstra
2009-10-07 14:45 ` Peter Zijlstra
2009-10-07 16:45 ` Arun R Bharadwaj
2009-10-07 16:45 ` Arun R Bharadwaj
2009-10-08 5:54 ` Arun R Bharadwaj
2009-10-08 5:54 ` Arun R Bharadwaj
2009-10-06 15:32 ` [v7 PATCH 4/7]: POWER: enable cpuidle for POWER Arun R Bharadwaj
2009-10-06 15:32 ` Arun R Bharadwaj
2009-10-06 15:32 ` Arun R Bharadwaj
2009-10-06 15:33 ` [v7 PATCH 5/7]: pSeries/cpuidle: remove dedicate/shared idle loops, which will be moved to arch/powerpc/platforms/pseries/processor_idle.c Arun R Bharadwaj
2009-10-06 15:33 ` Arun R Bharadwaj
2009-10-06 15:33 ` Arun R Bharadwaj
2009-10-06 15:34 ` [v7 PATCH 6/7]: POWER: add a default_idle idle loop for POWER Arun R Bharadwaj
2009-10-06 15:34 ` Arun R Bharadwaj
2009-10-06 15:34 ` Arun R Bharadwaj
2009-10-06 15:35 ` [v7 PATCH 7/7]: pSeries: implement pSeries processor idle module Arun R Bharadwaj
2009-10-06 15:35 ` Arun R Bharadwaj
2009-10-06 15:35 ` Arun R Bharadwaj
2009-10-07 13:50 ` Arun R Bharadwaj
2009-10-07 13:50 ` Arun R Bharadwaj
2009-10-07 13:50 ` Arun R Bharadwaj
2009-10-06 16:35 ` [v7 PATCH 0/7]: cpuidle/x86/POWER: Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER Arun R Bharadwaj
2009-10-06 16:35 ` Arun R Bharadwaj
2009-10-06 16:35 ` Arun R Bharadwaj
2009-10-06 18:04 ` Peter Zijlstra
2009-10-06 18:04 ` Peter Zijlstra
2009-10-07 11:26 ` Vaidyanathan Srinivasan
2009-10-07 11:26 ` Vaidyanathan Srinivasan
2009-10-07 11:47 ` Balbir Singh
2009-10-07 11:47 ` Balbir Singh
2009-10-07 13:24 ` Peter Zijlstra [this message]
2009-10-07 13:24 ` Peter Zijlstra
2009-10-07 13:05 ` Peter Zijlstra
2009-10-07 13:05 ` Peter Zijlstra
2009-10-07 13:05 ` Peter Zijlstra
2009-10-07 13:05 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254921857.26976.249.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=arun@linux.vnet.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.